plugin-api 2.0 #81
Merged
plugin-api 2.0 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # this is temporary for the feature/plugin-api-2_0 branch and is meant for travis testing | ||
| gem "logstash-core", :path => "./logstash/logstash-core" |
There was a problem hiding this comment.
curious, won't this hinder plugin authors? Like if they 'git clone' this repo and want to run the test suite, it's probably not going to find logstash-core in ./logstash/logstash-core
There was a problem hiding this comment.
yeah, this is temporary for this refactor branch and will be removed once we are ready to merge back in master. this is just to allow Travis to build on that branch without having to publish ai core gems. see https://github.com/logstash-plugins/logstash-filter-grok/blob/feature/plugin-api-2_0/.travis.yml#L9
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastic/logstash/pull/5170 elastic/logstash/issues/5141