-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update this plugin to the v2.0 of the plugin api #29
Conversation
insist { subject["message"]["os"] } == "Linux" | ||
insist { subject["message"]["major"] } == "26" | ||
insist { subject["message"]["minor"] } == "0" | ||
insist { subject.get("message")["name"] } == "Chrome" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from our discussion about what is "proper" usage of the event api, shouldn't this change into
subject.get("[message][name]")
what do you think?
updated with your changes. |
@talevy ^ |
insist { subject["ua"]["os"] } == "Linux" | ||
insist { subject["ua"]["major"] } == "26" | ||
insist { subject["ua"]["minor"] } == "0" | ||
insist { subject.get("ua")["name"] } == "Chrome" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes still needed here? and below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, I just changed at the end of the file
LGTM |
No description provided.