Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Event API refactor #5140

Closed
1 of 4 tasks
colinsurprenant opened this issue Apr 19, 2016 · 1 comment
Closed
1 of 4 tasks

[meta] Event API refactor #5140

colinsurprenant opened this issue Apr 19, 2016 · 1 comment

Comments

@colinsurprenant
Copy link
Contributor

colinsurprenant commented Apr 19, 2016

This is a tracking issue related to the Event API refactor which will break compatibility for the 5.0 release.

Historically it was assumed that the returned values from the Ruby Event hash-like interface or the Event#to_hash method were returning references to the Event inner data and that modifying these references in turn also update the Event inner data.

Moving forward, this is an implementation specific side-effect that we will not support. To help in avoiding the confusion that the Ruby hash-like interface provides and also to force a breaking change in the API we have decided to completely remove the Ruby hash-like interface and instead expose proper getters and setters.

The direct consequence is that all unmodified plugins and Ruby filters are likely to crash and we believe this is better than having Ruby filters or plugins that will silently stop to work correctly.

Required Modifications

Optional Modifications

@suyograo
Copy link
Contributor

Focusing on #5141 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants