Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed console error, which appears when saving changes in Edit Alert flyout #83610

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fixed console error, which appears when saving changes in Edit Alert flyout #83610

merged 1 commit into from
Nov 18, 2020

Conversation

YulNaumenko
Copy link
Contributor

Resolve #83030

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 labels Nov 18, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner November 18, 2020 05:48
@YulNaumenko YulNaumenko self-assigned this Nov 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +4.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ymao1
ymao1 approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified console error no longer appears.

Maybe you can make use of some of the new typings from this PR? #83278

mikecote
mikecote approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@YulNaumenko YulNaumenko merged commit 3651748 into elastic:master Nov 18, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Nov 18, 2020
@YulNaumenko
Fixed console error, which appears when saving changes in Edit Alert …
a01d6df 
…flyout (elastic#83610)
@YulNaumenko YulNaumenko mentioned this pull request Nov 18, 2020
Merged
YulNaumenko added a commit that referenced this pull request Nov 19, 2020
@YulNaumenko
Fixed console error, which appears when saving changes in Edit Alert …
985b405 
…flyout (#83610) (#83725)
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 19, 2020
@phillipb
Merge branch 'add-logs-to-node-details' of github.com:phillipb/kibana…
2249140 
… into add-logs-to-node-details

* 'add-logs-to-node-details' of github.com:phillipb/kibana: (87 commits)
  [Maps] Add 'crossed' & 'exited' events to tracking alert (elastic#82463)
  Updating code-owners to use new core/app-services team names (elastic#83731)
  Add Managed label to data streams and a view switch for the table (elastic#83049)
  [Maps] Add query bar inputs to geo threshold alerts tracked points & boundaries (elastic#80871)
  fix(NA): search examples kibana version declaration (elastic#83182)
  Fixed console error, which appears when saving changes in Edit Alert flyout (elastic#83610)
  [Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578)
  Not resetting server log level if level is defined (elastic#83651)
  disable incremenetal build for legacy tsconfig.json (elastic#82986)
  [Workplace Search] Migrate SourceLogic from ent-search (elastic#83593)
  [Workplace Search] Port Box changes from ent-search (elastic#83675)
  [APM] Improve router types (elastic#83620)
  Bump flat to v4.1.1 (elastic#83647)
  Bump y18n@5 to v5.0.5 (elastic#83644)
  Bump jsonpointer to v4.1.0 (elastic#83641)
  Bump is-my-json-valid to v2.20.5 (elastic#83642)
  [Telemetry] Move Monitoring collection strategy to a collector (elastic#82638)
  Update typescript eslint to v4.8 (elastic#83520)
  [ML] Persist URL state for Anomaly detection jobs using metric function (elastic#83507)
  [ML] Performance improvements to annotations editing in Single Metric Viewer & buttons placement (elastic#83216)
  ...
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 19, 2020
@YulNaumenko @chrisronline
Fixed console error, which appears when saving changes in Edit Alert …
692c0a2 
…flyout (elastic#83610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting UI] Console error appears when saving changes in Edit Alert flyout
5 participants
@YulNaumenko @elasticmachine @kibanamachine @mikecote @ymao1