[ML] Persist URL state for Anomaly detection jobs using metric function #83507

qn895 · 2020-11-17T00:20:23Z

Summary

This PR is a follow up of #81662. It brings several improvements such as:

Persist the function description if the function is of type metric (for when user bookmarks or refreshes the page)
Avoid double fetching due to stale or unknown function description. Previously, switching to another detector and then back to the metric detector will fetch the aggregation data twice due to race condition.

Behavior

By default, when first viewing the job in the Single Metric Viewer, it will pick the function description associated with the highest anomaly scoring record. In this example, the view defaults to min.

Upon changing the plotting function and refresh of the page, the view will be persisted to the previously selected function.

Checklist

Delete any items that are not applicable to this PR.

This was checked for cross-browser compatibility

.../application/timeseriesexplorer/components/plot_function_controls/plot_function_controls.tsx

darnautov · 2020-11-17T13:33:35Z

.../application/timeseriesexplorer/components/plot_function_controls/plot_function_controls.tsx

 }: {
  functionDescription: undefined | string;
  setFunctionDescription: (func: string) => void;
+  selectedDetectorIndex: any;
+  selectedJobId: string;
+  selectedEntities: Record<string, any>;


Could it be a more specific type?

Updated here 607d788

@qn895 can't find it in the commit hash you've mentioned

Not sure why Github is being weird but it's https://github.com/elastic/kibana/pull/83507/commits/607d7880884564514d8fb34b4972bc4ab644ea75

.../ml/public/application/timeseriesexplorer/timeseriesexplorer_utils/get_viewable_detectors.ts

x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js

elasticmachine · 2020-11-17T14:20:24Z

Pinging @elastic/ml-ui (:ml)

…func-desc-in-url

darnautov

LGTM, just some minor issues left

darnautov · 2020-11-18T09:14:53Z

.../application/timeseriesexplorer/components/plot_function_controls/plot_function_controls.tsx

+      _selectedDetectorIndex: number,
+      _selectedEntities: Record<string, any>,
+      _selectedJobId: string,
+      _selectedJob: CombinedJob


I believe you don't need it and can access these arguments from the component scope

I think doing that will require the callback to depend on those arguments, and since they are the same as the original effect we're splitting it from, I don't see the benefits of either moving it outside of the effect or using the arguments from component scope.

x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js

peteharverson

Tested and LGTM

qn895 · 2020-11-18T15:17:32Z

@elasticmachine merge upstream

kibanamachine · 2020-11-18T16:56:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 104f440

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1565	1566	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	5.2MB	5.2MB	+1017.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	67.3KB	67.4KB	+144.0B

History

💚 Build #88395 succeeded e3adf61
💚 Build #88204 succeeded df2dc85

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…on (elastic#83507) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

… into add-logs-to-node-details * 'add-logs-to-node-details' of github.com:phillipb/kibana: (87 commits) [Maps] Add 'crossed' & 'exited' events to tracking alert (elastic#82463) Updating code-owners to use new core/app-services team names (elastic#83731) Add Managed label to data streams and a view switch for the table (elastic#83049) [Maps] Add query bar inputs to geo threshold alerts tracked points & boundaries (elastic#80871) fix(NA): search examples kibana version declaration (elastic#83182) Fixed console error, which appears when saving changes in Edit Alert flyout (elastic#83610) [Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578) Not resetting server log level if level is defined (elastic#83651) disable incremenetal build for legacy tsconfig.json (elastic#82986) [Workplace Search] Migrate SourceLogic from ent-search (elastic#83593) [Workplace Search] Port Box changes from ent-search (elastic#83675) [APM] Improve router types (elastic#83620) Bump flat to v4.1.1 (elastic#83647) Bump y18n@5 to v5.0.5 (elastic#83644) Bump jsonpointer to v4.1.0 (elastic#83641) Bump is-my-json-valid to v2.20.5 (elastic#83642) [Telemetry] Move Monitoring collection strategy to a collector (elastic#82638) Update typescript eslint to v4.8 (elastic#83520) [ML] Persist URL state for Anomaly detection jobs using metric function (elastic#83507) [ML] Performance improvements to annotations editing in Single Metric Viewer & buttons placement (elastic#83216) ...

…on (elastic#83507) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…function (#83507) (#83673) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

qn895 added 4 commits November 16, 2020 17:52

[ML] Lift to props

3794a7e

[ML] Remove redundant code

e35b174

[ML] Move isMetricDetector

16d30cb

[ML] Move getViewableDetectors

df2dc85

qn895 added Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 17, 2020

qn895 requested review from walterra, darnautov and peteharverson November 17, 2020 00:20

qn895 requested a review from a team as a code owner November 17, 2020 00:20

qn895 self-assigned this Nov 17, 2020

darnautov reviewed Nov 17, 2020

View reviewed changes

peteharverson added the :ml label Nov 17, 2020

qn895 mentioned this pull request Nov 17, 2020

[ML] Persisted state in the URL, improve browser history navigation #83033

Closed

7 tasks

qn895 added 5 commits November 17, 2020 12:12

Merge remote-tracking branch 'upstream/master' into ml-metric-saving-…

8c094c6

…func-desc-in-url

[ML] Remove console

53dc467

[ML] Update selectedDetectorIndex: num

607d788

[ML] Move getFunctionDescriptionToPlot out

1b10541

[ML] Remove lodash each

e3adf61

darnautov approved these changes Nov 18, 2020

View reviewed changes

peteharverson approved these changes Nov 18, 2020

View reviewed changes

Merge branch 'master' into ml-metric-saving-func-desc-in-url

104f440

qn895 merged commit 77da781 into elastic:master Nov 18, 2020

qn895 deleted the ml-metric-saving-func-desc-in-url branch November 18, 2020 16:57

qn895 added a commit to qn895/kibana that referenced this pull request Nov 18, 2020

[ML] Persist URL state for Anomaly detection jobs using metric functi…

ee2c5d0

…on (elastic#83507) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

qn895 mentioned this pull request Nov 18, 2020

[7.x] [ML] Persist URL state for Anomaly detection jobs using metric function (#83507) #83673

Merged

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 19, 2020

[ML] Persist URL state for Anomaly detection jobs using metric functi…

b9d37aa

…on (elastic#83507) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

qn895 mentioned this pull request Nov 20, 2020

[ML] Fix Single Metric Viewer not loading if job is metric with no partition #83880

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Persist URL state for Anomaly detection jobs using metric function #83507

[ML] Persist URL state for Anomaly detection jobs using metric function #83507

qn895 commented Nov 17, 2020 •

edited

Loading

darnautov Nov 17, 2020

qn895 Nov 17, 2020

darnautov Nov 18, 2020

qn895 Nov 18, 2020

elasticmachine commented Nov 17, 2020

darnautov left a comment

darnautov Nov 18, 2020

qn895 Nov 18, 2020

peteharverson left a comment

qn895 commented Nov 18, 2020

kibanamachine commented Nov 18, 2020

[ML] Persist URL state for Anomaly detection jobs using metric function #83507

[ML] Persist URL state for Anomaly detection jobs using metric function #83507

Conversation

qn895 commented Nov 17, 2020 • edited Loading

Summary

Behavior

Checklist

darnautov Nov 17, 2020

Choose a reason for hiding this comment

qn895 Nov 17, 2020

Choose a reason for hiding this comment

darnautov Nov 18, 2020

Choose a reason for hiding this comment

qn895 Nov 18, 2020

Choose a reason for hiding this comment

elasticmachine commented Nov 17, 2020

darnautov left a comment

Choose a reason for hiding this comment

darnautov Nov 18, 2020

Choose a reason for hiding this comment

qn895 Nov 18, 2020

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

qn895 commented Nov 18, 2020

kibanamachine commented Nov 18, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

qn895 commented Nov 17, 2020 •

edited

Loading