[Maps] Add 'crossed' & 'exited' events to tracking alert

[kindsun]

In addition to entered, adds exited and crossed conditionds to geo threshold alert

This doesn't change the nature of the ES query, but instead just the filters applied to the response.

Note: This may change significantly (or disappear) when the query shifts to tracking containment rather than the current crossing logic, but since the work is already complete and containment isn't fully fleshed out, this functionality should be merged to augment the existing logic.

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[thomasneirynck]

thx for enabling!

I'm not sure if we should retain the current way that instance-ids are generated:

ie.

kibana/x-pack/plugins/stack_alerts/server/alert_types/geo_threshold/geo_threshold.ts

Line 257 in 25c5daa

.alertInstanceFactory(`${entityName}-${toBoundaryName || currLocation.shapeId}`)

For exiting, shouldn't the instance-id be the shape-boundary where it come from. Since the currLocaiton.shapeId will always be outside.

(I didn't test, more open ended question now)

[kindsun]

thx for enabling!

I'm not sure if we should retain the current way that instance-ids are generated:

ie.

kibana/x-pack/plugins/stack_alerts/server/alert_types/geo_threshold/geo_threshold.ts

Line 257 in 25c5daa

.alertInstanceFactory(`${entityName}-${toBoundaryName || currLocation.shapeId}`)

For exiting, shouldn't the instance-id be the shape-boundary where it come from. Since the currLocaiton.shapeId will always be outside.

(I didn't test, more open ended question now)

Mhm, good catch. It also gets stranger for crossing. We could do something like:

• Entered: ${entityName}-${toBoundaryName || currLocation.shapeId}
• Exited: ${entityName}-${fromBoundaryName || prevLocation.shapeId}
• Crossed: ${entityName}-${fromBoundaryName || prevLocation.shapeId}-${toBoundaryName || currLocation.shapeId}

[thomasneirynck]

Entered: ${entityName}-${toBoundaryName || currLocation.shapeId}
Exited: ${entityName}-${fromBoundaryName || prevLocation.shapeId}
Crossed: ${entityName}-${fromBoundaryName || prevLocation.shapeId}-${toBoundaryName || currLocation.shapeId}

+1 from me.

maybe @kmartastic can chime in, since this is very user-facing.

[kindsun]

Entered: ${entityName}-${toBoundaryName || currLocation.shapeId}
Exited: ${entityName}-${fromBoundaryName || prevLocation.shapeId}
Crossed: ${entityName}-${fromBoundaryName || prevLocation.shapeId}-${toBoundaryName || currLocation.shapeId}
+1 from me.

maybe @kmartastic can chime in, since this is very user-facing.

@thomasneirynck Discussed with @kmartastic offline and he approved the suggested changes. Updates pushed!

Crossing example (note: it does get tricky with hyphenated names, but maybe that's ok):

[thomasneirynck]

thanks, remains pretty readable to me.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 05610fe

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
stackAlerts	79.6KB	79.7KB	+30.0B

History

• 💔 Build #88725 failed 0fec225
• 💚 Build #88109 succeeded 803d6a6
• 💔 Build #88096 failed aac319b
• 💚 Build #85576 succeeded db8ccd6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream