Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix APM lodash imports #78438

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Fix APM lodash imports #78438

merged 5 commits into from
Sep 28, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Sep 24, 2020

No description provided.

@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 24, 2020
@smith smith requested a review from a team as a code owner September 24, 2020 15:06
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith
Copy link
Contributor Author

smith commented Sep 24, 2020

retest

@smith
Copy link
Contributor Author

smith commented Sep 28, 2020

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Sep 28, 2020

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Sep 28, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
apm 1255 -2 1257

async chunks size

id value diff baseline
apm 4.1MB -2.6KB 4.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 33e3aa2 into elastic:master Sep 28, 2020
@smith smith deleted the nls/lodash-imports branch September 28, 2020 17:37
@smith smith mentioned this pull request Sep 28, 2020
Merged
smith added a commit to smith/kibana that referenced this pull request Sep 28, 2020
@smith
Fix APM lodash imports (elastic#78438)
82e2fc2 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/apm/public/components/app/ServiceMap/Cytoscape.tsx
#	x-pack/plugins/apm/public/components/app/ServiceMap/use_cytoscape_event_handlers.ts
@smith smith mentioned this pull request Sep 28, 2020
Closed
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 28, 2020
@gmmorris
Merge branch 'master' into task-manager/health
6b81d56 
* master:
  Fix APM lodash imports (elastic#78438)
  Add deprecated message to tile_map and region_map visualizations. (elastic#77683)
  Fix Lens smokescreen flaky tests (elastic#78566)
  updated discover with alt text (elastic#77660)
  Fix types (elastic#78619)
  Update tutorial-visualizing.asciidoc (elastic#76977)
  Update tutorial-discovering.asciidoc (elastic#76976)
  [Search] Error notification alignment (elastic#77788)
  Update tutorial-define-index.asciidoc (elastic#76975)
  [Lens] Fieldless operations (elastic#78080)
  [Usage Collection] [schema] Explicit "array" definition (elastic#78141)
  Update tutorial-define-index.asciidoc (elastic#76973)
  Fix --no-basepath references in doc (elastic#78570)
  Move StubIndexPattern to data plugin and convert to TS. (elastic#78518)
  Index pattern class - remove unused methods (elastic#78538)
  [Security Solution] [ALL] Eliminates all console.error and console.warn from Jest output (elastic#78523)
  [Actions] avoids setting a default dedupKey on PagerDuty (elastic#77773)
  First stab at developer-focussed saved objects docs (elastic#71430)
  remove unnecessary config validations (elastic#78527)
scottybollinger pushed a commit to scottybollinger/kibana that referenced this pull request Sep 28, 2020
@smith @elasticmachine @scottybollinger
Fix APM lodash imports (elastic#78438)
dd52e43 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
smith added a commit that referenced this pull request Sep 28, 2020
@smith
Fix APM lodash imports (#78438) (#78652)
42985cd 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/apm/public/components/app/ServiceMap/Cytoscape.tsx
#	x-pack/plugins/apm/public/components/app/ServiceMap/use_cytoscape_event_handlers.ts
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
@phillipb
Merge branch 'add-anomalies-to-timeline' of github.com:phillipb/kiban…
ecee577 
…a into add-anomalies-to-timeline

* 'add-anomalies-to-timeline' of github.com:phillipb/kibana: (89 commits)
  Aligns several module versions across the repository (elastic#78327)
  Empty prompt and loading spinner for service map (elastic#78382)
  Change progress bar to spinner (elastic#78460)
  [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111)
  Slim down core bundle (elastic#75912)
  [Alerting] retry internal OCC calls within alertsClient (elastic#77838)
  [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656)
  [Ingest Manager] Ingest setup upgrade (elastic#78081)
  [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520)
  fix name without a category or if field end with .text (elastic#78655)
  [Security Solution] [Detections] Log message enhancements (elastic#78429)
  [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303)
  [Enterprise Search] Remove all instances of KibanaContext to Kea store (elastic#78513)
  [ML] DF Analytics creation: ensure job did not fail to start before showing results link (elastic#78200)
  fix createAppNavigationHandler to use `navigateToUrl` (elastic#78583)
  Fixing a11y test failure on discover app (elastic#59975) (elastic#77614)
  [Security Solution] Initiate endpoint package upgrade from security app (elastic#77498)
  [kbn/es] use a basic build process (elastic#78090)
  [kbn/optimizer] fix .json extension handling (elastic#78524)
  Fix APM lodash imports (elastic#78438)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smith @elasticmachine @kibanamachine @sorenlouv