[Security Solution] Initiate endpoint package upgrade from security app #77498

jonathan-buttner · 2020-09-15T15:07:14Z

This PR will check to see if the endpoint package is installed and up to date when a user navigates to the security solution. It will perform the check on all of the tabs within the app and will run when a user navigates between the tabs.

There's no notification to the user as that work was postponed for now.

Before attempting to get information about the endpoint package, the component will check the current user's permissions to see if they are privileged enough to do the installation.

This PR is waiting for: #77827 to be merged and then a all the ingest manager will go away.

Endpoint Package Upgrade GIF

jonathan-buttner · 2020-09-15T21:04:04Z

x-pack/plugins/security_solution/public/app/index.tsx

@@ -30,6 +31,7 @@ export const renderApp = ({
 }: RenderAppProps) => {
  render(
    <SecurityApp apolloClient={apolloClient} history={history} services={services} store={store}>
+      <UpgradeEndpointPackage />


@oatkiller @paul-tavares is this the right place to do this if we want the functionality to run on any of the tabs? We'll probably want to the upgrade check to run as often as possible.

Also @XavierM any thoughts?

Actually having it run when a user navigates between tab seems a bit excessive. If you have ideas for limiting this so it only runs when the user initially navigates to any page on the security app that'd be helpful. That way we don't have to perform the api requests when we navigate between tabs.

Yes, I think we can add that in the start plugin.js, and we can store it in the reducer store and then have a component reading this value to show something or not. what do you think?

I have PR which going to merge in master soon and can show you what we did there.

Thanks @XavierM, is this the PR? https://github.com/elastic/kibana/pull/77192/files

@XavierM will that cause the code to run less frequently?
@jonathan-buttner Why is it important that the code runs less frequently?

After discussing this with Rob, I think we're just going to stick with doing it when any of the plugins are started because it's more simple.

jonathan-buttner · 2020-09-15T21:06:58Z

x-pack/plugins/security_solution/public/app/upgrade.ts

+ * @param packageKey a string in the form of <package name>-<package version>
+ * @param options an object containing options for the request
+ */
+const sendGetPackageInfo = async (


@oatkiller @paul-tavares where should these functions live? The management and policy pages have some similar functions and are within a services directory under those pages https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/management/pages/policy/store/policy_list/services/ingest.ts#L137

I would defer to @XavierM or @spong for this. I don't know about the structure of this part of the app.

...lugins/security_solution/public/management/pages/policy/store/policy_list/services/ingest.ts

x-pack/plugins/security_solution/public/app/upgrade.ts

…int-package

elasticmachine · 2020-09-24T14:18:42Z

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

XavierM · 2020-09-24T17:16:32Z

I am just wondering if we need to add telemetry over there, to know if we are doing or not. It might be already done on the back end.

jonathan-buttner · 2020-09-24T18:17:52Z

I am just wondering if we need to add telemetry over there, to know if we are doing or not. It might be already done on the back end.

Oh good point. @michaelolo24 @skh do you recall if we have telemetry on the installed packages via the ingest manager? So when a package is installed/upgraded will that be reflected in the telemetry?

bkimmel · 2020-09-28T15:38:51Z

x-pack/plugins/security_solution/public/app/home/index.tsx

@@ -58,6 +59,8 @@ const HomePageComponent: React.FC<HomePageProps> = ({ children }) => {
  const [showTimeline] = useShowTimeline();

  const { browserFields, indexPattern, indicesExist } = useSourcererScope();
+  // side effect: this will attempt to upgrade the endpoint package if it is not up to date


❔ Elaborating to explain when/how often that will happen and why may be helpful to the reader.

bkimmel · 2020-09-28T15:42:30Z

x-pack/plugins/security_solution/public/common/hooks/endpoint/upgrade.ts

+    const abortController = new AbortController();
+
+    // cancel any ongoing requests
+    const cleanup = () => {


❔ cleanup as a name suggests this should always be done, which is a little confusing because this sends an abort through the connection. Rename or clarify, perhaps?

bkimmel

Left a few questions

jonathan-buttner · 2020-09-28T16:43:14Z

I am just wondering if we need to add telemetry over there, to know if we are doing or not. It might be already done on the back end.

Oh good point. @michaelolo24 @skh do you recall if we have telemetry on the installed packages via the ingest manager? So when a package is installed/upgraded will that be reflected in the telemetry?

@XavierM The ingest manager app handles collecting telemetry on the installed packages: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/server/collectors/package_collectors.ts

kibanamachine · 2020-09-28T18:12:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fedc630

Metrics [docs]

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	1970	+1	1969

async chunks size

id	value	diff	baseline
securitySolution	10.2MB	+4.3KB	10.2MB

History

💚 Build #76938 succeeded 44c32d9
💚 Build #76297 succeeded 3c400fe
💚 Build #75699 succeeded 810b203
💚 Build #74797 succeeded 3667f85
💛 Build #74617 was flaky dc9303d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…pp (elastic#77498) * Working on package update functionality * Correctly installing package * Moving upgrade component and working upgrade * Doing permissions check * Cleaning up imports * Adding bulk upgrade api * Addressing comments * Removing todo * Changing body field * Adding helper for getting the bulk install route * Adding request spec * Using bulk install endpoint from ingest * Moving component to a hook * Addressing feedback

…pp (#77498) (#78660) * Working on package update functionality * Correctly installing package * Moving upgrade component and working upgrade * Doing permissions check * Cleaning up imports * Adding bulk upgrade api * Addressing comments * Removing todo * Changing body field * Adding helper for getting the bulk install route * Adding request spec * Using bulk install endpoint from ingest * Moving component to a hook * Addressing feedback

…a into add-anomalies-to-timeline * 'add-anomalies-to-timeline' of github.com:phillipb/kibana: (89 commits) Aligns several module versions across the repository (elastic#78327) Empty prompt and loading spinner for service map (elastic#78382) Change progress bar to spinner (elastic#78460) [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111) Slim down core bundle (elastic#75912) [Alerting] retry internal OCC calls within alertsClient (elastic#77838) [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656) [Ingest Manager] Ingest setup upgrade (elastic#78081) [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520) fix name without a category or if field end with .text (elastic#78655) [Security Solution] [Detections] Log message enhancements (elastic#78429) [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303) [Enterprise Search] Remove all instances of KibanaContext to Kea store (elastic#78513) [ML] DF Analytics creation: ensure job did not fail to start before showing results link (elastic#78200) fix createAppNavigationHandler to use `navigateToUrl` (elastic#78583) Fixing a11y test failure on discover app (elastic#59975) (elastic#77614) [Security Solution] Initiate endpoint package upgrade from security app (elastic#77498) [kbn/es] use a basic build process (elastic#78090) [kbn/optimizer] fix .json extension handling (elastic#78524) Fix APM lodash imports (elastic#78438) ...

jonathan-buttner added 2 commits September 14, 2020 18:43

Working on package update functionality

1a3506e

Correctly installing package

5d39443

jonathan-buttner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0 labels Sep 15, 2020

jonathan-buttner added 2 commits September 15, 2020 16:00

Moving upgrade component and working upgrade

5c3a58f

Doing permissions check

ebaae00

jonathan-buttner commented Sep 15, 2020

View reviewed changes

jonathan-buttner requested review from paul-tavares, oatkiller, bkimmel, michaelolo24 and kqualters-elastic September 15, 2020 21:11

jonathan-buttner added 3 commits September 15, 2020 17:15

Cleaning up imports

dc9303d

Merge branch 'master' of github.com:elastic/kibana into upgrade-endpo…

3667f85

…int-package

Adding bulk upgrade api

76df74d

jonathan-buttner mentioned this pull request Sep 17, 2020

[Ingest Manager] Adding bulk packages upgrade api #77827

Merged

jonathan-buttner added 12 commits September 18, 2020 14:33

Addressing comments

6dea606

Removing todo

268c526

Resolving conflicts

04a39bd

Merge branch 'master' of github.com:elastic/kibana into upgrade-endpo…

f3d3979

…int-package

Merge branch 'ingest-bulk-upgrade' into upgrade-endpoint-package

8eb2cea

Changing body field

f111406

Merge branch 'ingest-bulk-upgrade' into upgrade-endpoint-package

5e19070

Adding helper for getting the bulk install route

2846b76

Merge branch 'ingest-bulk-upgrade' into upgrade-endpoint-package

3fffaef

Adding request spec

20357fd

Merge branch 'ingest-bulk-upgrade' into upgrade-endpoint-package

ff0cbce

Using bulk install endpoint from ingest

810b203

jonathan-buttner added 3 commits September 22, 2020 15:19

Resolving conflicts

3c400fe

Moving component to a hook

b8a9fc7

Fixing merge conflicts

44c32d9

jonathan-buttner marked this pull request as ready for review September 24, 2020 14:18

jonathan-buttner requested review from a team as code owners September 24, 2020 14:18

jonathan-buttner requested a review from patrykkopycinski September 24, 2020 17:14

bkimmel reviewed Sep 28, 2020

View reviewed changes

bkimmel approved these changes Sep 28, 2020

View reviewed changes

jonathan-buttner added 2 commits September 28, 2020 12:24

Pulling changes from master

46699bd

Addressing feedback

fedc630

XavierM approved these changes Sep 28, 2020

View reviewed changes

jonathan-buttner merged commit 768ae21 into elastic:master Sep 28, 2020

jonathan-buttner deleted the upgrade-endpoint-package branch September 28, 2020 18:18

jonathan-buttner mentioned this pull request Sep 28, 2020

[7.x] [Security Solution] Initiate endpoint package upgrade from security app (#77498) #78660

Merged

jonathan-buttner mentioned this pull request Oct 1, 2020

[Security Solution][Exceptions] Add lowercase normalizer for case-insensitivity + deprecate _tags field (new OS field) #77379

Merged

3 tasks

rw-access mentioned this pull request Jun 9, 2021

[Detections] Adds automatic updating for Prebuilt Security Detection Rules package #101846

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Initiate endpoint package upgrade from security app #77498

[Security Solution] Initiate endpoint package upgrade from security app #77498

jonathan-buttner commented Sep 15, 2020 •

edited

Loading

jonathan-buttner Sep 15, 2020

jonathan-buttner Sep 16, 2020

jonathan-buttner Sep 23, 2020

XavierM Sep 23, 2020 •

edited

Loading

jonathan-buttner Sep 24, 2020

oatkiller Sep 24, 2020

jonathan-buttner Sep 24, 2020

jonathan-buttner Sep 15, 2020

oatkiller Sep 24, 2020

elasticmachine commented Sep 24, 2020

XavierM commented Sep 24, 2020

jonathan-buttner commented Sep 24, 2020 •

edited

Loading

bkimmel Sep 28, 2020

bkimmel Sep 28, 2020

bkimmel left a comment

jonathan-buttner commented Sep 28, 2020

kibanamachine commented Sep 28, 2020

[Security Solution] Initiate endpoint package upgrade from security app #77498

[Security Solution] Initiate endpoint package upgrade from security app #77498

Conversation

jonathan-buttner commented Sep 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XavierM Sep 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Sep 24, 2020

XavierM commented Sep 24, 2020

jonathan-buttner commented Sep 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkimmel left a comment

Choose a reason for hiding this comment

jonathan-buttner commented Sep 28, 2020

kibanamachine commented Sep 28, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

History

jonathan-buttner commented Sep 15, 2020 •

edited

Loading

XavierM Sep 23, 2020 •

edited

Loading

jonathan-buttner commented Sep 24, 2020 •

edited

Loading