Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Use default imports from lodash #73937

Closed
dgieselaar opened this issue Jul 31, 2020 · 2 comments
Closed

[APM] Use default imports from lodash #73937

dgieselaar opened this issue Jul 31, 2020 · 2 comments
Assignees
Labels
discuss good first issue low hanging fruit Team:APM All issues that need APM UI Team support

Comments

@dgieselaar
Copy link
Member

Using named imports for lodash includes the whole of Lodash into the bundle. We can try default imports for a smaller bundle.

From:
import { mapValues } from 'lodash'

To:
import mapValues from 'lodash/mapValues'

@dgieselaar dgieselaar added the Team:APM All issues that need APM UI Team support label Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith
Copy link
Contributor

smith commented Sep 28, 2020

Since Lodash is now in shared deps, we want to do the opposite. See #78438, #78156, #78100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss good first issue low hanging fruit Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants