Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fixing y axis on transaction error rate to 100% #77609

Merged
merged 2 commits into from
Sep 17, 2020
Merged

[APM] Fixing y axis on transaction error rate to 100% #77609

merged 2 commits into from
Sep 17, 2020

Conversation

cauemarcondes
Copy link
Contributor

Before:
Screenshot 2020-09-16 at 15 17 15

After:
Screenshot 2020-09-16 at 15 12 43

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 16, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner September 16, 2020 13:17
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes changed the title fixing y axis on transaction error rate to 100% [APM] Fixing y axis on transaction error rate to 100% Sep 16, 2020
sorenlouv
sorenlouv approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 5.0MB +14.0B 5.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@formgeist
Copy link
Contributor

formgeist commented Sep 16, 2020 •
edited
Loading

I had a comment ready to be sent earlier but forgot about it. I would propose to have a minimum y-axis range, maybe at 1% so we always have three labels. Setting the y-axis max to 100% might not be good because the error rate would normally be somewhere around 5-10 depending on the service, which then makes it hard to see a change in rate. Having it set to max makes sense to keep.

@cauemarcondes cauemarcondes merged commit 94a4fc9 into elastic:master Sep 17, 2020
@cauemarcondes cauemarcondes deleted the apm-error-rate branch September 17, 2020 06:35
@cauemarcondes cauemarcondes mentioned this pull request Sep 17, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Sep 17, 2020
@cauemarcondes @elasticmachine
[APM]fixing y axis on transaction error rate to 100% (elastic#77609)
2de51dc 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@formgeist
Copy link
Contributor

@cauemarcondes I reviewed it on master and it's very clear that the scale set to 100%, it'll be very easy to miss whether you have sudden increases in error rate because the rates are lower than you might expect.

Screenshot 2020-09-17 at 10 55 07

Kapture 2020-09-17 at 10 56 09

A jump from 1 -> 8% is quite a lot, but it's hardly seen on the chart.

Not sure by merging if you wanted to follow up with another PR to look at setting a min scale and continue to use max for anything above? I can also open a new issue if that's better.

@cauemarcondes
Copy link
Contributor Author

Not sure by merging if you wanted to follow up with another PR to look at setting a min scale and continue to use max for anything above? I can also open a new issue if that's better.

@formgeist would you mind opening a new bug? you can already assign it to me.

cauemarcondes added a commit that referenced this pull request Sep 17, 2020
@cauemarcondes @elasticmachine
[APM]fixing y axis on transaction error rate to 100% (#77609) (#77707)
e6a792d 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@formgeist
Copy link
Contributor

@cauemarcondes sure, no problem 👍

@formgeist
Copy link
Contributor

I've opened #77741

jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 18, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
6a85bac 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (140 commits)
  Add telemetry as an automatic privilege grant (elastic#77390)
  [Security Solutions][Cases] Cases Redesign (elastic#73247)
  Use Search API in TSVB (elastic#76274)
  [Mappings editor] Add support for constant_keyword field type (elastic#76564)
  [ML] Adds ML modules for Metrics UI Integration (elastic#76460)
  [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER (elastic#76771)
  Migrate status & stats APIs to KP + remove legacy status lib (elastic#76054)
  use App updater API instead of deprecated chrome.navLinks.update (elastic#77708)
  [CSM Dashboard] Remove points from line chart (elastic#77617)
  [APM] Trace timeline: Replace multi-fold function icons with new EuiIcon glyphs (elastic#77470)
  [Observability] Overview: Alerts section style improvements (elastic#77670)
  Bump the Node.js version used by Docker in CI (elastic#77714)
  Upgrade all minimist (sub)dependencies to version ^1.2.5 (elastic#60284)
  Remove unneeded forced package resolutions (elastic#77467)
  [ML] Add metrics app to check made for internal custom URLs (elastic#77627)
  Functional tests - add supertest for test_user (elastic#77584)
  [ML] Adding option to create AD jobs without starting the datafeed (elastic#77484)
  Bump node-fetch to 2.6.1 (elastic#77445)
  Bump sharkdown from v0.1.0 to v0.1.1 (elastic#77607)
  [APM]fixing y axis on transaction error rate to 100% (elastic#77609)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.container.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/text_editor.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/processors/grok.test.tsx
@smith
Copy link
Contributor

smith commented Oct 22, 2020

Tested in FF/Chrome/Safari. Looks good!

@smith smith added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cauemarcondes @elasticmachine @kibanamachine @formgeist @smith @sorenlouv