-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions][Cases] Cases Redesign #73247
Conversation
4078277
to
eb42273
Compare
eb42273
to
16e9ef8
Compare
Pinging @elastic/siem (Team:SIEM) |
e3967aa
to
a218b31
Compare
a218b31
to
3968616
Compare
x-pack/plugins/security_solution/public/cases/components/create/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/add_comment/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/tag_list/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/user_action_tree/index.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/security_solution/public/cases/components/user_action_tree/user_action_avatar.tsx
Show resolved
Hide resolved
...plugins/security_solution/public/cases/components/user_action_tree/user_action_copy_link.tsx
Show resolved
Hide resolved
.../security_solution/public/cases/components/user_action_tree/user_action_property_actions.tsx
Outdated
Show resolved
Hide resolved
.../security_solution/public/cases/components/user_action_tree/user_action_property_actions.tsx
Outdated
Show resolved
Hide resolved
d8a04d8
to
357b620
Compare
x-pack/plugins/security_solution/public/cases/components/user_action_tree/index.tsx
Outdated
Show resolved
Hide resolved
90de912
to
df937d9
Compare
df937d9
to
aafbc26
Compare
x-pack/plugins/security_solution/public/common/components/link_to/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job to bring us back with EUI!!! I really enjoyed reading the refactor around the EuiCommentList, it is perfect NOW!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - focused on just updating the detection's use of the new markdown component. It all worked really great, thank you so much for these updates!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
48407f0
to
aa50719
Compare
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This is awesome, thanks @cnasikas
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…rok/new-patterns-component-use-array * 'master' of github.com:elastic/kibana: (140 commits) Add telemetry as an automatic privilege grant (elastic#77390) [Security Solutions][Cases] Cases Redesign (elastic#73247) Use Search API in TSVB (elastic#76274) [Mappings editor] Add support for constant_keyword field type (elastic#76564) [ML] Adds ML modules for Metrics UI Integration (elastic#76460) [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER (elastic#76771) Migrate status & stats APIs to KP + remove legacy status lib (elastic#76054) use App updater API instead of deprecated chrome.navLinks.update (elastic#77708) [CSM Dashboard] Remove points from line chart (elastic#77617) [APM] Trace timeline: Replace multi-fold function icons with new EuiIcon glyphs (elastic#77470) [Observability] Overview: Alerts section style improvements (elastic#77670) Bump the Node.js version used by Docker in CI (elastic#77714) Upgrade all minimist (sub)dependencies to version ^1.2.5 (elastic#60284) Remove unneeded forced package resolutions (elastic#77467) [ML] Add metrics app to check made for internal custom URLs (elastic#77627) Functional tests - add supertest for test_user (elastic#77584) [ML] Adding option to create AD jobs without starting the datafeed (elastic#77484) Bump node-fetch to 2.6.1 (elastic#77445) Bump sharkdown from v0.1.0 to v0.1.1 (elastic#77607) [APM]fixing y axis on transaction error rate to 100% (elastic#77609) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.container.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.scss # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/text_editor.scss # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/processors/grok.test.tsx
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
This PR redesign the case details page using the new EuiCommentList component and the new Markdown editor.
Screenshots
Markdown editor
Timeline editor
Timeline popup
Timeline preview
Syntax help
Edit actions
Tag actions
Case with actions
Comment with a timeline
Checklist
Delete any items that are not applicable to this PR.
For maintainers