Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER #76771

Merged
merged 7 commits into from
Sep 17, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 4, 2020

Summary

We are not sure yet if we want this change

In case there is multiple points in context of VALUE_CLICK_TRIGGER (e.g. heat map cell clicked) currently URL Drilldown is showing a popup asking user to pick a value to drilldown to.

This pr extends event variables from VALUE_CLICK_TRIGGER to support multiple points:

Before:

When attaching a click to a heat map cell user don't have control over array of points:

{
key: string,
value: string,
negate: boolean
}

Screenshot 2020-09-04 at 15 11 18

After:

URL template can use all the points:

{
key: string,
value: string,
negate: boolean
points: Array<{key: string, value: string}>
}

Screenshot 2020-09-04 at 14 36 24


This change gives more flexibility and control to a user, but it also extends api surface.
This is a quick way to solve this corner case, that would work. But we are not sure if we want go with this.
This corner case and other corner cases described in details in this issue: #76226

@Dosant Dosant added discuss v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes Feature:Drilldowns Embeddable panel Drilldowns v7.10.0 labels Sep 4, 2020
@Dosant Dosant requested a review from a team as a code owner September 4, 2020 13:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

…down-multiple-values

# Conflicts:
#	x-pack/plugins/embeddable_enhanced/public/plugin.ts
@Dosant Dosant changed the title [Drilldowns][discuss] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER Sep 14, 2020
@Dosant Dosant removed the discuss label Sep 14, 2020
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally, LGTM.

@Dosant
Copy link
Contributor Author

Dosant commented Sep 17, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
embeddableEnhanced 15 -126 141

page load bundle size

id value diff baseline
embeddableEnhanced 40.0KB -52.3KB 92.3KB
uiActions 268.1KB +4.0B 268.1KB
total -52.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant added a commit to Dosant/kibana that referenced this pull request Sep 17, 2020
elastic#76771)

{{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant added a commit that referenced this pull request Sep 17, 2020
#76771) (#77754)

{{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 18, 2020
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (140 commits)
  Add telemetry as an automatic privilege grant (elastic#77390)
  [Security Solutions][Cases] Cases Redesign (elastic#73247)
  Use Search API in TSVB (elastic#76274)
  [Mappings editor] Add support for constant_keyword field type (elastic#76564)
  [ML] Adds ML modules for Metrics UI Integration (elastic#76460)
  [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER (elastic#76771)
  Migrate status & stats APIs to KP + remove legacy status lib (elastic#76054)
  use App updater API instead of deprecated chrome.navLinks.update (elastic#77708)
  [CSM Dashboard] Remove points from line chart (elastic#77617)
  [APM] Trace timeline: Replace multi-fold function icons with new EuiIcon glyphs (elastic#77470)
  [Observability] Overview: Alerts section style improvements (elastic#77670)
  Bump the Node.js version used by Docker in CI (elastic#77714)
  Upgrade all minimist (sub)dependencies to version ^1.2.5 (elastic#60284)
  Remove unneeded forced package resolutions (elastic#77467)
  [ML] Add metrics app to check made for internal custom URLs (elastic#77627)
  Functional tests - add supertest for test_user (elastic#77584)
  [ML] Adding option to create AD jobs without starting the datafeed (elastic#77484)
  Bump node-fetch to 2.6.1 (elastic#77445)
  Bump sharkdown from v0.1.0 to v0.1.1 (elastic#77607)
  [APM]fixing y axis on transaction error rate to 100% (elastic#77609)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.container.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/text_editor.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/processors/grok.test.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants