-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Swallow errors in opt-in remote notification from the server #75641
[Telemetry] Swallow errors in opt-in remote notification from the server #75641
Conversation
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we log these somewhere to track how many times we encounter them? I'd prefer us knowing about their frequency rather than blinding swallowing them.
…llow-opt-in-remote-notification
dcee693
to
0bc6b96
Compare
@TinaHeiligers fair point! I've added the log entry. I've tested it by setting
|
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/kibana-core (Team:Core) |
Summary
This PR catches any errors when the server tries to notify the remote telemetry service about Opt-In/Opt-Out events but it can't reach it for whatever reason.
We are not awaiting the promise anymore to avoid timing out the Kibana request when the connection to the remote service times out.
Fixes #75637
For maintainers