Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry] Swallow errors in opt-in remote notification from the server #75641

Merged
merged 3 commits into from
Aug 24, 2020
Merged

[Telemetry] Swallow errors in opt-in remote notification from the server #75641

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d153ae
[Telemetry] Swallow errors in opt-in remote notification from the server
afharo Aug 21, 2020
9499207
Merge branch 'master' of github.com:elastic/kibana into telemetry/swa…
afharo Aug 24, 2020
0bc6b96
Log the opt-in notification error
afharo Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/plugins/telemetry/server/routes/telemetry_opt_in.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,13 @@ export function registerTelemetryOptInRoutes({

if (config.sendUsageFrom === 'server') {
const optInStatusUrl = config.optInStatusUrl;
await sendTelemetryOptInStatus(
sendTelemetryOptInStatus(
telemetryCollectionManager,
{ optInStatusUrl, newOptInStatus },
statsGetterConfig
);
).catch(() => {
// Swallow this error. The server is likely behind a firewall and can't reach the remote service
});
}

await updateTelemetrySavedObject(context.core.savedObjects.client, attributes);
Expand Down