-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drilldowns for TSVB / Vega / Timelion #74848
Drilldowns for TSVB / Vega / Timelion #74848
Conversation
src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
Outdated
Show resolved
Hide resolved
src/plugins/vis_type_timeseries/public/application/components/vis_editor.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-app (Team:KibanaApp) |
Oh, that's interesting, I didn't know that we go this route with high level apply filter trigger for those vis types, I thought the plan is go forward with kibana_table unification and go from there :D cool! |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested TSVB with dashboard-to-dashboard drilldown and example drilldowns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested it on safari, works fine for all 🥳
* Drilldowns for TSVB / Vega Closes: elastic#60611 * fix PR comment * fix PR comments * add support for Timelion * rename vis.API.events.brush -> vis.API.events.applyFilter
* master: Fix bug on TopN weird behavior with zero values (elastic#74942) [Lens] Fix table sorting bug (elastic#74902) [SECURITY_SOLUTION] Retry on ingest setup (elastic#75000) [file upload] lazy load to reduce page load size (elastic#74967) Drilldowns for TSVB / Vega / Timelion (elastic#74848) [EventLog] Populate alert instances view with event log data (elastic#68437) [UiActions] pass trigger into action execution context (elastic#74363)
Closes: #60611 #60613
Summary
Add support of drilldowns for TSVB / Vega
Range
event from dashboard to dashboardRange
event from dashboard to dashboardSome tips how to test drilldows in VEGA
Checklist
Delete any items that are not applicable to this PR.
For maintainers