Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drilldowns for TSVB / Vega / Timelion #74848

Merged
merged 6 commits into from
Aug 14, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 12, 2020

Closes: #60611 #60613

Summary

Add support of drilldowns for TSVB / Vega

  • Timelion currently supports only Range event from dashboard to dashboard
  • TSVB currently supports only Range event from dashboard to dashboard
  • Vega vis supports both 'Range' and 'Filter' events

Some tips how to test drilldows in VEGA

  • Range Event:
{
$schema: https://vega.github.io/schema/vega/v5.json
marks: [{
  type: text
  encode: { update: { text: { value: "Click here" } } }
}]
signals: [ {
  on: [{
  events: click
  update: kibanaSetTimeFilter("2019", "2020")
  }]
}]}
  • Filter Event:
{
$schema: https://vega.github.io/schema/vega/v5.json
marks: [{
  type: text
  encode: { update: { text: { value: "Click here" } } }
}]
signals: [ {
  on: [{
  events: click
  update: kibanaAddFilter({ match_phrase: { response: "200" }})
  }]
}]}

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@alexwizp alexwizp changed the title Drilldowns for TSVB / Vega Drilldowns for TSVB / Vega / Timeline Aug 13, 2020
@alexwizp alexwizp changed the title Drilldowns for TSVB / Vega / Timeline Drilldowns for TSVB / Vega / Timelion Aug 13, 2020
@alexwizp alexwizp self-assigned this Aug 13, 2020
@alexwizp alexwizp added Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0 release_note:enhancement labels Aug 13, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
visTypeTimeseries 1.8MB -135.0B 1.8MB
visTypeVega 1.4MB +217.0B 1.4MB
total +82.0B

page load bundle size

id value diff baseline
visTypeTimelion 712.3KB +396.0B 711.9KB
visTypeTimeseries 280.5KB +172.0B 280.3KB
visTypeVega 661.6KB +459.0B 661.2KB
visualizations 409.0KB +585.0B 408.4KB
total +1.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich mentioned this pull request Aug 13, 2020
5 tasks
@alexwizp alexwizp marked this pull request as ready for review August 13, 2020 16:11
@alexwizp alexwizp requested a review from a team August 13, 2020 16:11
@alexwizp alexwizp requested a review from a team as a code owner August 13, 2020 16:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@Dosant
Copy link
Contributor

Dosant commented Aug 13, 2020

Oh, that's interesting, I didn't know that we go this route with high level apply filter trigger for those vis types, I thought the plan is go forward with kibana_table unification and go from there :D cool!

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested TSVB with dashboard-to-dashboard drilldown and example drilldowns

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested it on safari, works fine for all 🥳

@alexwizp alexwizp merged commit f6f59ec into elastic:master Aug 14, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 14, 2020
* Drilldowns for TSVB / Vega

Closes: elastic#60611

* fix PR comment

* fix PR comments

* add support for Timelion

* rename vis.API.events.brush -> vis.API.events.applyFilter
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 14, 2020
* master:
  Fix bug on TopN weird behavior with zero values (elastic#74942)
  [Lens] Fix table sorting bug (elastic#74902)
  [SECURITY_SOLUTION] Retry on ingest setup (elastic#75000)
  [file upload] lazy load to reduce page load size (elastic#74967)
  Drilldowns for TSVB / Vega / Timelion (elastic#74848)
  [EventLog] Populate alert instances view with event log data (elastic#68437)
  [UiActions] pass trigger into action execution context (elastic#74363)
alexwizp added a commit that referenced this pull request Aug 14, 2020
* Drilldowns for TSVB / Vega

Closes: #60611

* fix PR comment

* fix PR comments

* add support for Timelion

* rename vis.API.events.brush -> vis.API.events.applyFilter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) Feature:Vega Vega visualizations release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drilldowns for TSVB
6 participants