-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UiActions] pass trigger into action execution context #74363
Merged
Dosant
merged 23 commits into
elastic:master
from
Dosant:dev/ui-actions-improve-context-2
Aug 14, 2020
Merged
[UiActions] pass trigger into action execution context #74363
Dosant
merged 23 commits into
elastic:master
from
Dosant:dev/ui-actions-improve-context-2
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-improve-context
…s-improve-context # Conflicts: # src/plugins/ui_actions/public/actions/action.ts # src/plugins/ui_actions/public/context_menu/build_eui_context_menu_panels.tsx # src/plugins/ui_actions/public/triggers/trigger_internal.ts
…s-improve-context
…bana into dev/ui-actions-improve-context
@elasticmachine merge upstream |
1 similar comment
@elasticmachine merge upstream |
…kibana into dev/ui-actions-improve-context-2
2 tasks
Dosant
changed the title
Dev/ui actions improve context 2
[UiActions] pass trigger into action execution context
Aug 10, 2020
Dosant
added
Feature:UIActions
UI actions. These are client side only, not related to the server side actions..
Team:AppArch
labels
Aug 10, 2020
Dosant
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
labels
Aug 10, 2020
streamich
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome, LGTM.
@elasticmachine merge upstream |
Pinging @elastic/kibana-app-arch (Team:AppArch) |
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
page load bundle size
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Aug 14, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant
added a commit
that referenced
this pull request
Aug 14, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 14, 2020
* master: Fix bug on TopN weird behavior with zero values (elastic#74942) [Lens] Fix table sorting bug (elastic#74902) [SECURITY_SOLUTION] Retry on ingest setup (elastic#75000) [file upload] lazy load to reduce page load size (elastic#74967) Drilldowns for TSVB / Vega / Timelion (elastic#74848) [EventLog] Populate alert instances view with event log data (elastic#68437) [UiActions] pass trigger into action execution context (elastic#74363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Embedding
Embedding content via iFrame
Feature:UIActions
UI actions. These are client side only, not related to the server side actions..
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses: #63854
This is a follow up on #71675 which takes a bit different (more strict) approach.
Reason why I didn't like #71675 is that it was super easy to not pass
trigger
into action handler.I even missed some places in that pr.
This pr takes different approach:
We already have a separation between
Action
andActionDefinition
.Those are used almost interchangeably in different places, which is confusing. The usage should be aligned in #74501:
Action
should be used internally and should represent the object returned by uiActions serviceActionDefinition
is a simple interface and should be used for registering an action in uiAction service.With that:
As
ActionDefinition
should stay as simple and flexible as possible to provide the simplest api for defining and action, argument type of handlers do not required to specify trigger.So when defining an action as
ActionDefinition
usage stays the same in simple cases:But if need to access context, consumer could use type helper:
But in Action interface trigger is required now.
So if consumer uses action directly or defines an action using
Action
interface instead ofActionDefinition
then:Action
,ActionDefinition
,createAction
are used interchangeably and intersect with each other. These interface usage should be documented and aligned: #74501