Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drilldowns for TSVB #60611

Closed
streamich opened this issue Mar 19, 2020 · 2 comments · Fixed by #74848
Closed

Drilldowns for TSVB #60611

streamich opened this issue Mar 19, 2020 · 2 comments · Fixed by #74848
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed

Comments

@streamich
Copy link
Contributor

streamich commented Mar 19, 2020

We need to make TSVB range brushing work with Drilldowns. TSVB does not support click events but it has brushing support, which we can use in Drilldowns.

Preliminary assessment:

  • TSVB is a vis_type rendered by visualize_embeddable.
  • visualize_embeddable executes SELECT_RANGE_TRIGGER that is used by Drilldowns.
  • To execute that trigger vis_type has to emit brush event.
  • However it seems that when brushing in TSVB it directly applies the filters without emitting the brush event in vis_type.

Related: #59654 #60613

Parent issue: #60232

@streamich streamich added Feature:Drilldowns Embeddable panel Drilldowns Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed labels Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@streamich
Copy link
Contributor Author

In TSVB visualization the onBrush handler:

this.onBrush = createBrushHandler(getDataStart().query.timefilter.timefilter);

Should emit vis_type brush event, instead of setting global filters:

timefilter.setTime({
from: moment(from).toISOString(),
to: moment(to).toISOString(),
mode: TIME_MODE,
});

@streamich streamich mentioned this issue May 4, 2020
2 tasks
@alexwizp alexwizp mentioned this issue Jun 21, 2020
7 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Aug 12, 2020
alexwizp added a commit that referenced this issue Aug 14, 2020
* Drilldowns for TSVB / Vega

Closes: #60611

* fix PR comment

* fix PR comments

* add support for Timelion

* rename vis.API.events.brush -> vis.API.events.applyFilter
alexwizp added a commit to alexwizp/kibana that referenced this issue Aug 14, 2020
* Drilldowns for TSVB / Vega

Closes: elastic#60611

* fix PR comment

* fix PR comments

* add support for Timelion

* rename vis.API.events.brush -> vis.API.events.applyFilter
alexwizp added a commit that referenced this issue Aug 14, 2020
* Drilldowns for TSVB / Vega

Closes: #60611

* fix PR comment

* fix PR comments

* add support for Timelion

* rename vis.API.events.brush -> vis.API.events.applyFilter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants