-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drilldowns for TSVB #69634
Drilldowns for TSVB #69634
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Checked on Mac/Chrome.
From AppArch sync, maybe this unified type for both brush triggers could work: interface RangeSelectTriggerEvent {
table?: KibanaDatatable;
column?: number;
range: Range;
timeFieldName?: string;
}
interface Range {
from: number;
to: number;
} |
@streamich @ppisljar Could you please explain your proposal cause it's not too clear for me? But firstly let me give you some context. The main problem is that we need to generate a Interface of that methods looks like:
Now let's go to you proposal and try to generate From my point of view the right interface for Brush (and probably click) event should look like:
If you agree with this, then this PR step in the right direction =) |
@elasticmachine merge upstream |
After discussions with @ppisljar we decided to put this on hold for now, since the drilldowns infrastructure is too tightly coupled with the "classical visualizations" infrastructure. We'll need to address the alignment of data tables (#68457) across Kibana first (which will make the required metadata a high level concept of those data structures), and then App Arch needs to cleanup the trigger parameters to be less visualization specific. |
@alexwizp As this is on hold for now, can we close the PR or put it back into draft mode? It's kicking off automation about PRs requiring review for me. Edit: Closed accidentally, I'll leave it up to you :) |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Closes: #60611
Summary
We need to make TSVB range brushing work with Drilldowns. TSVB does not support click events but it has brushing support, which we can use in Drilldowns.
Checklist
Delete any items that are not applicable to this PR.
For maintainers