Drilldowns for TSVB

[alexwizp]

Closes: #60611

Summary

We need to make TSVB range brushing work with Drilldowns. TSVB does not support click events but it has brushing support, which we can use in Drilldowns.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[alexwizp]

@elasticmachine merge upstream

[alexwizp]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[alexwizp]

@elasticmachine merge upstream

[streamich]

LGTM. Checked on Mac/Chrome.

[streamich]

From AppArch sync, maybe this unified type for both brush triggers could work:

interface RangeSelectTriggerEvent {
  table?: KibanaDatatable;
  column?: number;
  range: Range;
  timeFieldName?: string;
}

interface Range {
  from: number;
  to: number;
}

[alexwizp]

@streamich @ppisljar Could you please explain your proposal cause it's not too clear for me? But firstly let me give you some context.

The main problem is that we need to generate a RangeFilter (it's not a Range). Currently it's possible on by calling esFilters.buildRangeFilter from data plugin.

Interface of that methods looks like:

export const buildRangeFilter = (
  field: IFieldType,
  params: RangeFilterParams,
  indexPattern: IIndexPattern,
  formattedValue?: string
): RangeFilter => {

Now let's go to you proposal and try to generate RangeFilter using your interface.
As we see above it's not enough to pass only RangeFilterParams. With params we also need to pass required field and indexPattern. We can probably do it only using table (KibanaDatatable) field. But how to create that object from TSVB cause TSVB doesn't use KibanaDatatable and AggConfigs at all.

From my point of view the right interface for Brush (and probably click) event should look like:

interface RangeSelectTriggerEvent {
  timeRangeFilter: RangeFilter;
  filters: Filter[];
  timeFieldName: string;  // < not sure about it cause  timeRangeFilter already has this data
}

If you agree with this, then this PR step in the right direction =)

[alexwizp]

@elasticmachine merge upstream

[timroes]

After discussions with @ppisljar we decided to put this on hold for now, since the drilldowns infrastructure is too tightly coupled with the "classical visualizations" infrastructure. We'll need to address the alignment of data tables (#68457) across Kibana first (which will make the required metadata a high level concept of those data structures), and then App Arch needs to cleanup the trigger parameters to be less visualization specific.

[flash1293]

@alexwizp As this is on hold for now, can we close the PR or put it back into draft mode? It's kicking off automation about PRs requiring review for me.

Edit: Closed accidentally, I'll leave it up to you :)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 7b64070

Build metrics

✅ unchanged

History

• 💚 Build #55860 succeeded 7b64070
• 💚 Build #55495 succeeded f7ba824
• 💚 Build #55420 succeeded 1fd9851
• 💔 Build #55412 failed 9af45e0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream