Stabilize closing toast #72097
Merged
Stabilize closing toast #72097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:skip
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Expand to view the summary
Build stats
|
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jul 22, 2020
* stabilize closing toast * unskip test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # test/functional/apps/dashboard/dashboard_snapshots.js # test/functional/page_objects/common_page.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 22, 2020
* master: (23 commits) Stabilize closing toast (elastic#72097) stabilize failing test (elastic#72086) Stabilize filter bar test (elastic#72032) Unskip vislib tests (elastic#71452) [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689) fix preAuth/preRouting mocks (elastic#72663) [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788) [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584) [Security Solution] Fixes exception modal not loading content (elastic#72770) [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748) [Detections] Add validation for Threshold value field (elastic#72611) [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730) [Security Solution][Detections] Validate file type of value lists (elastic#72746) [pre-req] New Component Layout proposal (elastic#72385) [ML] do not throw an error when agg is not supported by UI (elastic#72685) [Resolver] Origin process (elastic#72382) [Ingest Manager] Allow to force unenroll from the UI (elastic#72386) skip 6.8 branch when triggering baseline-capture builds (elastic#72706) [CI] In-progress PR comments (elastic#72211) Fix sorting of scripted string fields (elastic#72681) ...
timroes
pushed a commit
that referenced
this pull request
Jul 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 22, 2020
* master: (34 commits) Adds Role Based Access-Control to the Alerting & Action plugins based on Kibana Feature Controls (elastic#67157) [Monitoring] Revert direct shipping code (elastic#72505) Use server basepath when creating reporting jobs (elastic#72722) Adding api test for transaction_groups /breakdown and /avg_duration_by_browser (elastic#72623) [Task Manager] Addresses flaky test introduced by buffered store (elastic#72815) [Observability] filter "hasData" api by processor event (elastic#72810) do not pass title as part of tsvb request (elastic#72619) [Lens] Legend config (elastic#70619) Stabilize closing toast (elastic#72097) stabilize failing test (elastic#72086) Stabilize filter bar test (elastic#72032) Unskip vislib tests (elastic#71452) [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689) fix preAuth/preRouting mocks (elastic#72663) [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788) [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584) [Security Solution] Fixes exception modal not loading content (elastic#72770) [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748) [Detections] Add validation for Threshold value field (elastic#72611) [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730) ...
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jul 24, 2020
* stabilize closing toast * unskip test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # test/functional/apps/dashboard/dashboard_snapshots.js # test/functional/page_objects/common_page.ts
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jul 27, 2020
* stabilize closing toast * unskip test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # test/functional/page_objects/common_page.ts
flash1293
added a commit
that referenced
this pull request
Jul 27, 2020
flash1293
added a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52854
In #58709 I introduced a safer toast closing function
closeToastIfExists, but turns out it wasn't safe enough - what's happening here is when it gets to check whether there is a toast, the toast is just about to get removed, but when the test tries to hit the close button, it's already detached from the DOM. It retries, but then it's gone completely:This PR just hides the error if the button can't be clicked, because this means the toast is already gone.