Stabilize closing toast (#72097) (#72814)

* stabilize closing toast * unskip test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # test/functional/apps/dashboard/dashboard_snapshots.js # test/functional/page_objects/common_page.ts
elastic · Jul 22, 2020 · 9a48ef4 · 9a48ef4
1 parent da374f8
commit 9a48ef4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/test/functional/apps/dashboard/dashboard_snapshots.js b/test/functional/apps/dashboard/dashboard_snapshots.js
@@ -28,9 +28,7 @@ export default function ({ getService, getPageObjects, updateBaselines }) {
   const dashboardPanelActions = getService('dashboardPanelActions');
   const dashboardAddPanel = getService('dashboardAddPanel');
 
-  // SKIPPED as it is failing in ES PROMOTION: https://github.com/elastic/kibana/issues/68595
-  // FLAKY: https://github.com/elastic/kibana/issues/52854
-  describe.skip('dashboard snapshots', function describeIndexTests() {
+  describe('dashboard snapshots', function describeIndexTests() {
     before(async function () {
       await esArchiver.load('dashboard/current/kibana');
       await kibanaServer.uiSettings.replace({

diff --git a/test/functional/page_objects/common_page.ts b/test/functional/page_objects/common_page.ts
@@ -401,7 +401,11 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
     async closeToastIfExists() {
       const toastShown = await find.existsByCssSelector('.euiToast');
       if (toastShown) {
-        await this.closeToast();
+        try {
+          await this.closeToast();
+        } catch (err) {
+          // ignore errors, toast clear themselves after timeout
+        }
       }
     }