[Transforms] Do not throw an error when agg is not supported by UI #72685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
bug
peteharverson
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Tested using the example which uses a bucket_script on the Flights sample data set in the docs, and was able to create the transform successfully.
I noted that the aggregation which uses the bucket_script doesn't appear in the preview table.
And if I use the popover to make an edit to the bucket_script aggregation after adding it to the transform e.g. to change the name of the aggregation, I see this error in the preview area:
@walterra are the above known issues?
Approving as this fixes the specific bug around not being able to add an aggregation using bucket_script.
peteharverson
pushed a commit
to peteharverson/kibana
that referenced
this pull request
Jul 22, 2020
peteharverson
pushed a commit
to peteharverson/kibana
that referenced
this pull request
Jul 22, 2020
This was referenced Jul 22, 2020
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jul 22, 2020
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jul 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 22, 2020
* master: (23 commits) Stabilize closing toast (elastic#72097) stabilize failing test (elastic#72086) Stabilize filter bar test (elastic#72032) Unskip vislib tests (elastic#71452) [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689) fix preAuth/preRouting mocks (elastic#72663) [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788) [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584) [Security Solution] Fixes exception modal not loading content (elastic#72770) [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748) [Detections] Add validation for Threshold value field (elastic#72611) [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730) [Security Solution][Detections] Validate file type of value lists (elastic#72746) [pre-req] New Component Layout proposal (elastic#72385) [ML] do not throw an error when agg is not supported by UI (elastic#72685) [Resolver] Origin process (elastic#72382) [Ingest Manager] Allow to force unenroll from the UI (elastic#72386) skip 6.8 branch when triggering baseline-capture builds (elastic#72706) [CI] In-progress PR comments (elastic#72211) Fix sorting of scripted string fields (elastic#72681) ...
peteharverson
added a commit
that referenced
this pull request
Jul 22, 2020
peteharverson
added a commit
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The function that resolves UI agg representation object from the JSON ES agg definition was throwing an error silently and preventing advanced JSON config editor to apply changes. Now it allows to add any aggregation and the validation happens only by calling the
_previewendpoint.