-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] landing page always being displayed #71494
[Observability] landing page always being displayed #71494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maps changes lgtm w/ green CI!
- code review
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observability change lgtm. Let's double check that the modifications to the tests are ok.
💚 Backport successfulThe PR was backported to the following branches:
|
* hides overview item when no other obs plugin is available. * reverting tests changes * reverting tests changes * adding overview to observability tests
Thanks for fixing this, y'all!!! |
* master: (21 commits) [Maps] 7.9 design improvements (elastic#71563) [ML] Changing all calls to ML endpoints to use internal user (elastic#70487) [eventLog] prevent log writing when initialization fails (elastic#71339) [Observability] landing page always being displayed (elastic#71494) [IM] Address data stream copy feedback (elastic#71615) [Logs UI] Anomalies page dataset filtering (elastic#71110) [data.search.aggs] Remove `use_field_mapping` from top hits agg (elastic#71168) [ML] Anomaly swim lane embeddable navigation and filter actions (elastic#71082) Fixes typo in siem_cloudtrail job description (elastic#71569) Require granted API Keys to have a name (elastic#71623) Update getUsageForCollection (elastic#71609) Only fetch saved elements once (elastic#71310) [SecuritySolution][Resolver] Adding siem index and guarding process ancestry (elastic#71570) [APM] Additional data telemetry changes (elastic#71112) [Visualize] Fix export table for table export links (elastic#71249) [Search] Server side search API (elastic#70446) use inclusive language (elastic#71607) [Security Solution] Hide timeline footer when Resolver is open (elastic#71516) [Index template wizard] Remove shadow and use border for components panels (elastic#71606) [ML] Kibana API endpoint for histogram chart data (elastic#70976) ...
* hides overview item when no other obs plugin is available. * reverting tests changes * reverting tests changes * adding overview to observability tests Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
if (!someVisible) { | ||
core.chrome.navLinks.update('observability-overview', { hidden: true }); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite late, but note that this is a deprecated API:
kibana/src/core/public/chrome/nav_links/nav_links_service.ts
Lines 76 to 82 in bf04235
* @deprecated Uses the {@link AppBase.updater$} property when registering | |
* your application with {@link ApplicationSetup.register} instead. | |
* | |
* @param id | |
* @param values | |
*/ | |
update(id: string, values: ChromeNavLinkUpdateableFields): ChromeNavLink | undefined; |
closes #68908
Reverting test changes that shouldn't have been made here 0d5b98d