[Observability] landing page always being displayed

[kobelb]

With the changes introduced by #67467, the Observability landing page is always being displayed, even when the user does not have access to any Observability features:

This page should only be displayed when the user has access to at least one Observability feature. It's very common for users to only be granted access to a single feature in Kibana, and users do not want the Observability overview page to be displayed in these scenarios.

That's why there were tests written to ensure that when a user is only granted access to a specific feature that only this feature in addition to stack management is displayed in the side navigation. When fixing this bug, please put these tests back to how they were.

[cauemarcondes]

Thanks for opening this issue @kobelb, I didn't know those tests intended to test this scenarios.

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[kobelb]

Thanks for opening this issue @kobelb, I didn't know those tests intended to test this scenarios.

No problem, this intended behavior isn't well known, and you are definitely not the first to stumble on it.

[sorenlouv]

Ouch, sorry Brandon!

I don't post this screenshot to call you out @cauemarcondes - on the contrary: this is a really good example of the importance of good test names. You had no idea you were breaking functionality by changing the test.

(from #67467 (comment))

When we fix this we might want to rename the tests to make the intended behaviour more clear.

[kobelb]

Ouch, sorry Brandon!

No apologies needed! I apologize if the phrasing in the original description made it seem like an apology was in order.

I definitely agree that the names of these tests should be improved, and it's not immediately clear why "Stack Management" is a part of them. There's an open issue that the Kibana Security team is working on to hide the Stack Management feature when the user isn't authorized to any of the management sections, and then we can change expect(navLinks).to.eql(['APM', 'Stack Management']); to expect(navLinks).to.eql(['APM']);, which should hopefully make this even more clear :)

[formgeist]

Hi Brandon,

I just wanted to raise this to provide some context to the Overview page itself. The landing pages are provided to serve as onboarding helpers for users who are interested in setting up Observability. So while the intention to hide it when no Observability apps are available is good, I still think there are reasons for keeping the landing page available even if the apps are disabled.

We'd guide the users to enable the related apps and provide the next steps in order to get setup.

We could then consider whether or not the Overview page would count as an app and can be disabled as well for users who definitively don't want Observability in their Kibana.

Looping in @tbragin @roncohen and @cyrille-leclerc for visibility.

[formgeist]

Just an update; we discussed in the Observability landing page working group and decided that it's better to follow the current logic and hide the Overview page as suggested. I didn't consider it from the standpoint of an admin intentionally disabling the apps to curate the experience of Kibana to e.g. fit their team's workspace.

[alexfrancoeur]

We're exploring when / how we can start deep linking to these overview and landing pages from Cloud. Can we expect this to be resolved for 7.9?

[cauemarcondes]

Can we expect this to be resolved for 7.9?

Hi @alexfrancoeur, yes, it's going to be released on 7.9

[alexfrancoeur]

Thanks @cauemarcondes!