[Search] Server side search API #70446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
delete search explorer
lizozom
force-pushed
the
search/server-side-search
branch
from
0ca8076
to
696215b
Compare
added 3 commits
July 8, 2020 01:07
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
lizozom
added
release_note:plugin_api_changes
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
lukasolson
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Played around with this locally, seems to be working. I did notice that we seem to be swallowing timeout errors now, but I'm not sure if it's related to this PR or not. I did leave a couple of minor comments below.
Eventually, we also need to figure out a way to expose a way for server-side code to poll at an interval (similar to what we do client-side), but I think that can be left for a future PR.
| context: RequestHandlerContext, | ||
| request: IEsSearchRequest, | ||
| options?: ISearchOptions | ||
| ) => Promise<IEsSearchResponse>; |
There was a problem hiding this comment.
I think this is fine for now but we may need to have a chat about how solutions teams/plugin developers may want to eventually return custom responses (other than IEsSearchResponse).
|
@elasticmachine merge upstream |
32 tasks
added 5 commits
July 13, 2020 16:55
… into search/server-side-search
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Jul 14, 2020
* [search] Refactor the way search strategies are registered/retrieved on the server * Fix types and tests and update docs * Fix failing test * Move strategy name into options * Remove FE strategies * TypeScript of hell delete search explorer * Fix search interceptor OSS tests * test cleanup * fix * return search wrapper * initial api * Shiny happy cleanup * docs * fix jest test * simplify strategy registration * fix rebase * fix rebase * fix backport * types * TS for strategy * docs Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom
added a commit
that referenced
this pull request
Jul 14, 2020
* [search] Refactor the way search strategies are registered/retrieved on the server * Fix types and tests and update docs * Fix failing test * Move strategy name into options * Remove FE strategies * TypeScript of hell delete search explorer * Fix search interceptor OSS tests * test cleanup * fix * return search wrapper * initial api * Shiny happy cleanup * docs * fix jest test * simplify strategy registration * fix rebase * fix rebase * fix backport * types * TS for strategy * docs Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 14, 2020
* master: (21 commits) [Maps] 7.9 design improvements (elastic#71563) [ML] Changing all calls to ML endpoints to use internal user (elastic#70487) [eventLog] prevent log writing when initialization fails (elastic#71339) [Observability] landing page always being displayed (elastic#71494) [IM] Address data stream copy feedback (elastic#71615) [Logs UI] Anomalies page dataset filtering (elastic#71110) [data.search.aggs] Remove `use_field_mapping` from top hits agg (elastic#71168) [ML] Anomaly swim lane embeddable navigation and filter actions (elastic#71082) Fixes typo in siem_cloudtrail job description (elastic#71569) Require granted API Keys to have a name (elastic#71623) Update getUsageForCollection (elastic#71609) Only fetch saved elements once (elastic#71310) [SecuritySolution][Resolver] Adding siem index and guarding process ancestry (elastic#71570) [APM] Additional data telemetry changes (elastic#71112) [Visualize] Fix export table for table export links (elastic#71249) [Search] Server side search API (elastic#70446) use inclusive language (elastic#71607) [Security Solution] Hide timeline footer when Resolver is open (elastic#71516) [Index template wizard] Remove shadow and use border for components panels (elastic#71606) [ML] Kibana API endpoint for histogram chart data (elastic#70976) ...
28 tasks
|
Can you please add a Dev Doc section in the PR Summary? Release notes pull the summary of the PR from the Dev Doc section. |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays predessors - anchor - successors in right orderStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays predessors - anchor - successors in right orderStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filter_bar·js.dashboard app using current data dashboard filter bar filter editor field list shows index pattern of vis when one is addedStandard OutStack Traceand 8 more failures, only showing the first 3. Build metricsSaved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #69333
This PR simplifies some of the server side search type script and exposes a server side search service.
Dev Docs
This PR introduces a new server side search API.
The request should contain the query DSL.
const searchPromise = dataStart.search.search(context, request, options);Note that in OSS, queries are executed synchronously. In Basic license, this API returns either the results, or for longer queries, it returns an ID that can be used to retrieve the results by polling.