[Reporting/Test] Add Functional test for download CSV #65401
Merged
+203
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
commented
May 5, 2020
|
|
||
| const REPORTS_FOLDER = path.resolve(__dirname, 'reports'); | ||
|
|
||
| export default function({ getService, getPageObjects }: FtrProviderContext) { |
There was a problem hiding this comment.
refactored these tests to screenshots.ts
tsullivan
commented
May 5, 2020
tsullivan
added
Feature:Functional Testing
(Deprecated) Feature:Reporting
2 tasks
|
user doesn't have permission to update head repository |
tsullivan
commented
May 7, 2020
| @@ -198,7 +198,7 @@ export async function FindProvider({ getService }: FtrProviderContext) { | |||
| if (isDisplayed) { | |||
| return descendant; | |||
| } else { | |||
| throw new Error('Element is not displayed'); | |||
| throw new Error(`Element "${selector}" is not displayed`); | |||
There was a problem hiding this comment.
I was getting some flakiness in the tests, so I added this debug.
I think the flaky is coming from using dashboardPanelActions.toggleContextMenu(savedSearchPanel) to open the panel share menu.
Let's see if this keeps turning out to be flaky.
dmlemeshko
reviewed
May 8, 2020
| const csvPath = path.resolve( | ||
| __dirname, | ||
| '../../../../../../target/functional-tests/downloads/Ecommerce Data.csv' | ||
| ); |
There was a problem hiding this comment.
nit: Spencer showed me a nice way to do it
import { REPO_ROOT } from '@kbn/dev-utils';
const csvPath = path.resolve(REPO_ROOT, 'target/functional-tests/downloads/Ecommerce Data.csv');
dmlemeshko
approved these changes
May 8, 2020
There was a problem hiding this comment.
Code LGTM.
Flaky test runner showed 30 passed: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/439/
|
@elasticmachine merge upstream |
|
user doesn't have permission to update head repository |
|
@elasticmachine merge upstream |
|
user doesn't have permission to update head repository |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 11, 2020
* [Reporting/Test] Add Functional test for download CSV * add todo * add fs.existsSync check to find download * debug * handle timeout * validate toast * different way of getting repo_root
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 11, 2020
* [Reporting/Test] Add Functional test for download CSV * add todo * add fs.existsSync check to find download * debug * handle timeout * validate toast * different way of getting repo_root
tsullivan
added a commit
that referenced
this pull request
May 11, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 12, 2020
* master: (46 commits) [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854) [functional/services] import By/until from module (elastic#66015) [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676) Inspect action shows on dashboard for every chart (elastic#65998) Fix heigt calc in calc issue for ie11 (elastic#66010) [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028) [SIEM] [Security] unified code structure phase 0 (elastic#65965) [Maps] Organize layers into subfolders (elastic#65513) skip flaky suite (elastic#59849) Cleanup prefill and edit flow. (elastic#66105) Fix major severity service map ring colors (elastic#66124) [DOCS] Improves formatting in action types (elastic#65932) [DOCS] APM Agent config: Setting values must be string (elastic#65875) Change default cert age limit value. (elastic#65918) [DOCS] Removed saved object options (elastic#66072) [SIEM] [Cases] Case API tests (elastic#65777) Add example of of local plugin installation (elastic#65986) skip flaky suite (elastic#65741) [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583) [Reporting/Test] Add Functional test for download CSV (elastic#65401) ...
tsullivan
added a commit
that referenced
this pull request
May 13, 2020
* [Reporting/Test] Add Functional test for download CSV * add todo * add fs.existsSync check to find download * debug * handle timeout * validate toast * different way of getting repo_root Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #65476
Reporting Team is preparing on making some changes to the Download CSV server-side code, but there is a gap in functional testing, as there are no existing functional tests for this feature.
We have API Integration tests running, which verify the server-side works when explicitly given all the POST parameters.
This PR adds functional tests for Download CSV. Since we are not able to check that the CSV file was successfully downloaded, this test validates that the button creates the correct POST parameters to send to the server and have it start the download.
Checklist