Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] APM Agent config: Option values must be string #65875

Merged
merged 2 commits into from
May 11, 2020
Merged

[DOCS] APM Agent config: Option values must be string #65875

merged 2 commits into from
May 11, 2020

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented May 8, 2020 •
edited
Loading

Since 7.7 agent config option values must be stringified

Invalid:

{
  "transaction_max_spans" : 500
}

Valid:

{
  "transaction_max_spans" : "500"
}

@sorenlouv sorenlouv requested review from a team and bmorelli25 May 8, 2020 15:59
@bmorelli25 bmorelli25 added the release_note:skip Skip the PR/issue when compiling release notes label May 8, 2020
bmorelli25
bmorelli25 approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All of the documentation builds are failing right now. I'll rerun the check when things are fixed.

@sorenlouv
Copy link
Member Author

retest

@sorenlouv
Copy link
Member Author

@elasticmachine merge upstream

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

2 similar comments
@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@sorenlouv sorenlouv merged commit 5b6a99a into master May 11, 2020
@sorenlouv sorenlouv deleted the apm-setting-values-must-be-strings branch May 11, 2020 21:17
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request May 11, 2020
@sorenlouv @elasticmachine
[DOCS] APM Agent config: Setting values must be string (elastic#65875)
8c5cd4b 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced May 11, 2020
Merged
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request May 11, 2020
@sorenlouv @elasticmachine
[DOCS] APM Agent config: Setting values must be string (elastic#65875)
95dceee 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sorenlouv sorenlouv mentioned this pull request May 11, 2020
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request May 11, 2020
@sorenlouv @elasticmachine
[DOCS] APM Agent config: Setting values must be string (elastic#65875)
8884cea 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sorenlouv added a commit that referenced this pull request May 12, 2020
@sorenlouv @elasticmachine
[DOCS] APM Agent config: Setting values must be string (#65875) (#66130)
b04daa7 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sorenlouv added a commit that referenced this pull request May 12, 2020
@sorenlouv @elasticmachine
[DOCS] APM Agent config: Setting values must be string (#65875) (#66131)
2f54528 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sorenlouv added a commit that referenced this pull request May 12, 2020
@sorenlouv @elasticmachine
[DOCS] APM Agent config: Setting values must be string (#65875) (#66132)
3e9bb4d 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 12, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-components
073a924 
* master: (46 commits)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854)
  [functional/services] import By/until from module (elastic#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676)
  Inspect action shows on dashboard for every chart (elastic#65998)
  Fix heigt calc in calc issue for ie11 (elastic#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028)
  [SIEM] [Security] unified code structure phase 0 (elastic#65965)
  [Maps] Organize layers into subfolders (elastic#65513)
  skip flaky suite (elastic#59849)
  Cleanup prefill and edit flow. (elastic#66105)
  Fix major severity service map ring colors (elastic#66124)
  [DOCS] Improves formatting in action types (elastic#65932)
  [DOCS] APM Agent config: Setting values must be string (elastic#65875)
  Change default cert age limit value. (elastic#65918)
  [DOCS] Removed saved object options (elastic#66072)
  [SIEM] [Cases] Case API tests (elastic#65777)
  Add example of of local plugin installation (elastic#65986)
  skip flaky suite (elastic#65741)
  [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583)
  [Reporting/Test] Add Functional test for download CSV (elastic#65401)
  ...
jloleysens added a commit that referenced this pull request May 12, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/pipel…
6316956 
…ine-editor

* 'master' of github.com:elastic/kibana: (37 commits)
  [APM] Correct relative paths in scripts (#66159)
  [Uptime] Enable deselection of stale filters (#65523)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854)
  [functional/services] import By/until from module (#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (#65676)
  Inspect action shows on dashboard for every chart (#65998)
  Fix heigt calc in calc issue for ie11 (#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (#66028)
  [SIEM] [Security] unified code structure phase 0 (#65965)
  [Maps] Organize layers into subfolders (#65513)
  skip flaky suite (#59849)
  Cleanup prefill and edit flow. (#66105)
  Fix major severity service map ring colors (#66124)
  [DOCS] Improves formatting in action types (#65932)
  [DOCS] APM Agent config: Setting values must be string (#65875)
  Change default cert age limit value. (#65918)
  [DOCS] Removed saved object options (#66072)
  [SIEM] [Cases] Case API tests (#65777)
  Add example of of local plugin installation (#65986)
  skip flaky suite (#65741)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorenlouv @bmorelli25 @elasticmachine