[Reporting] remove unused "immediate export" abstractions from esqueue worker cycles #65375
+14
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/dashboard-csv-download-maintainance
branch
from
ba4babd
to
5fe0845
Compare
tsullivan
changed the title
tsullivan
changed the title
tsullivan
force-pushed
the
reporting/dashboard-csv-download-maintainance
branch
from
564605a
to
b475b4c
Compare
tsullivan
force-pushed
the
reporting/dashboard-csv-download-maintainance
branch
from
b475b4c
to
ac34f92
Compare
tsullivan
added
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
This PR is entirely Typescript maintenance in 2 files. The original code seems over-eager to support a type of data (export type with different signature in the create/execute functions) which turns out to not be relevant here because immediate report generation is indeed handled outside of the queue/execute cycles. |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 7, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 8, 2020
…or-part-mvp-2 * 'master' of github.com:elastic/kibana: (259 commits) SavedObjects bulkCreate API should return migrationVersion and strip the type & namespace from the id (elastic#65150) Drilldown count tooltip (elastic#65105) plugins logs start with "plugins." prefix (elastic#65710) [ML] Fix pagination reset on search query update. (elastic#65668) [SIEM] Add types to the mappings objects so extra keys cannot be introduced [apm] Update machine learning flyout and service maps docs (elastic#65517) change api endpoint and throw error (elastic#65790) [Maps] remove SLA percentage metric (elastic#65718) [Reporting] APM integration for baseline performance measurements (elastic#59967) fix(NA): noParse regex for windows on kbn optimizer (elastic#65755) [ML] DFA: ensure at least one field is included in analysis before job can be created (elastic#65320) [Data plugin] cleanup - remove unused getRoutes / routes from indexPattern object (elastic#65683) Removed skip to enable test. (elastic#65575) [Lens] Type safe migrations (elastic#65576) [Canvas] Fix nav link behavior in Canvas (elastic#65590) [Event log] Fix flaky test (elastic#65658) [Alerting] changes preconfigured actions config from array to object (elastic#65397) remove immediate functions from esqueue worker cycles (elastic#65375) [Metrics UI] Fix isAbove to only display when threshold set (elastic#65540) draft search profiler accessibility tests (elastic#62357) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
tsullivan
added a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving the Reporting plugin's job management from ESQueue to Task Manager means first simplifying parts of the Reporting code that deal with queuing job (scheduling task) and executing the job (running the task).
Previous to this PR, there was an overcomplication in this parts of the code, because an unnecessary abstraction existed that added awareness of types of tasks that should execute immediately, instead of being queued.
It turns out those abstractions were not needed, because immediate task work doesn't come through this part of the code.
Checklist
Delete any items that are not applicable to this PR.
For maintainers
More testing on the affected feature is added here: #65401