Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable adding conditions when in alert management context. #63514

Merged

Conversation

phillipb
Copy link
Contributor

@phillipb phillipb commented Apr 14, 2020

Summary

This PR adds better handling for metric threshold alerts on the kibana alert management screen. Currently, there is an issue fetching metric field names. To work around this issue, we've disabled editing the metric name, and adding an alert condition. There is also now a callout with a link to redirect users to metrics explorer for creating new Metric Threshold alerts. This will NOT affect adding conditions from metrics explorer.

In 7.8, we'll support this much better. We need to port our source configuration over from graphql to a standard rest api. Once that's done, we will then be able to fetch the metric fields from anywhere in kibana.

Screen Shot 2020-04-14 at 2 16 58 PM

Screen Shot 2020-04-14 at 2 16 43 PM

Checklist

Delete any items that are not applicable to this PR.

@phillipb phillipb added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 labels Apr 14, 2020
@phillipb phillipb requested a review from a team as a code owner April 14, 2020 19:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@phillipb phillipb changed the title Disable adding conditions when in alert manament context. Disable adding conditions when in alert management context. Apr 14, 2020
@phillipb phillipb added the release_note:skip Skip the PR/issue when compiling release notes label Apr 14, 2020
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipb phillipb merged commit bf63b56 into elastic:master Apr 14, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 15, 2020
* master: (29 commits)
  Add test:jest_integration npm script (elastic#62938)
  [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548)
  [Discover] Fix broken setting of bucketInterval (elastic#62939)
  Disable adding conditions when in alert management context. (elastic#63514)
  [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432)
  adding useMemo (elastic#63504)
  [Maps] fix double fetch when filter pill is added (elastic#63024)
  [Lens] Fix missing formatting bug in "break down by" (elastic#63288)
  [SIEM] [Cases] Removed double pasted line (elastic#63507)
  [Reporting] Improve functional test steps (elastic#63259)
  [SIEM][CASE] Tests for server's configuration API (elastic#63099)
  [SIEM] [Cases] Case container unit tests (elastic#63376)
  [ML] Improving parsing of large uploaded files (elastic#62970)
  [ML] Listing global calendars on the job management page (elastic#63124)
  [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373)
  Add help text to form fields (elastic#63165)
  [ML] Converts utils Mocha tests to Jest (elastic#63132)
  [Metrics UI] Refactor With* containers to hooks (elastic#59503)
  [NP] Migrate logstash server side code to NP (elastic#63135)
  Clicking cancel in saved query save modal doesn't close it (elastic#62774)
  ...
phillipb added a commit to phillipb/kibana that referenced this pull request Apr 15, 2020
…63514)

* Disable adding conditions when in alert manament context.

* Fix typo

* Change id for i18n string
phillipb added a commit to phillipb/kibana that referenced this pull request Apr 15, 2020
…63514)

* Disable adding conditions when in alert manament context.

* Fix typo

* Change id for i18n string
phillipb added a commit that referenced this pull request Apr 15, 2020
…63556)

* Disable adding conditions when in alert manament context.

* Fix typo

* Change id for i18n string
phillipb added a commit that referenced this pull request Apr 15, 2020
…63557)

* Disable adding conditions when in alert manament context.

* Fix typo

* Change id for i18n string
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
* Disable adding conditions when in alert manament context.

* Fix typo

* Change id for i18n string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants