Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search.aggs] Remove service getters from agg types (AggConfig part) #62548

Merged
merged 10 commits into from
Apr 15, 2020

Conversation

VladLasitsa
Copy link
Contributor

Part of #60333

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@VladLasitsa VladLasitsa marked this pull request as ready for review April 8, 2020 07:53
@VladLasitsa VladLasitsa requested a review from a team as a code owner April 8, 2020 07:53
@VladLasitsa VladLasitsa self-assigned this Apr 8, 2020
@VladLasitsa VladLasitsa added release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.8.0 v8.0.0 labels Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't done a full review yet, just added an initial comment

src/plugins/data/public/search/aggs/agg_configs.ts Outdated Show resolved Hide resolved
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VladLasitsa
Copy link
Contributor Author

@lukeelmers, Could you please review again?

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, otherwise code LGTM!

src/plugins/data/public/search/aggs/agg_configs.ts Outdated Show resolved Hide resolved
src/plugins/data/public/search/aggs/agg_config.ts Outdated Show resolved Hide resolved
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa merged commit 18687a3 into elastic:master Apr 15, 2020
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Apr 15, 2020
…art) (elastic#62548)

* removed getFieldFormats from aggConfig

* made new properties is private

* Fixed ci

* Fixed tests

* Fixes clone method

* move filedFotmats inside opt fro AggConfigs

* Added readonly

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 15, 2020
* master: (29 commits)
  Add test:jest_integration npm script (elastic#62938)
  [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548)
  [Discover] Fix broken setting of bucketInterval (elastic#62939)
  Disable adding conditions when in alert management context. (elastic#63514)
  [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432)
  adding useMemo (elastic#63504)
  [Maps] fix double fetch when filter pill is added (elastic#63024)
  [Lens] Fix missing formatting bug in "break down by" (elastic#63288)
  [SIEM] [Cases] Removed double pasted line (elastic#63507)
  [Reporting] Improve functional test steps (elastic#63259)
  [SIEM][CASE] Tests for server's configuration API (elastic#63099)
  [SIEM] [Cases] Case container unit tests (elastic#63376)
  [ML] Improving parsing of large uploaded files (elastic#62970)
  [ML] Listing global calendars on the job management page (elastic#63124)
  [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373)
  Add help text to form fields (elastic#63165)
  [ML] Converts utils Mocha tests to Jest (elastic#63132)
  [Metrics UI] Refactor With* containers to hooks (elastic#59503)
  [NP] Migrate logstash server side code to NP (elastic#63135)
  Clicking cancel in saved query save modal doesn't close it (elastic#62774)
  ...
alexwizp pushed a commit that referenced this pull request Apr 15, 2020
…art) (#62548) (#63550)

* removed getFieldFormats from aggConfig

* made new properties is private

* Fixed ci

* Fixed tests

* Fixes clone method

* move filedFotmats inside opt fro AggConfigs

* Added readonly

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
…art) (#62548)

* removed getFieldFormats from aggConfig

* made new properties is private

* Fixed ci

* Fixed tests

* Fixes clone method

* move filedFotmats inside opt fro AggConfigs

* Added readonly

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants