Disable adding conditions when in alert management context. (#63514)

* Disable adding conditions when in alert manament context. * Fix typo * Change id for i18n string
elastic · Apr 14, 2020 · bf63b56 · bf63b56
1 parent 7677764
commit bf63b56
Showing 1 changed file with 117 additions and 62 deletions.
diff --git a/x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx b/x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx
@@ -17,6 +17,9 @@ import {
 import { IFieldType } from 'src/plugins/data/public';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { i18n } from '@kbn/i18n';
+import { EuiExpression } from '@elastic/eui';
+import { EuiCallOut } from '@elastic/eui';
+import { EuiLink } from '@elastic/eui';
 import {
   MetricExpressionParams,
   Comparator,
@@ -208,6 +211,37 @@ export const Expressions: React.FC<Props> = props => {
     }
   }, [alertsContext.metadata, defaultExpression, source]); // eslint-disable-line react-hooks/exhaustive-deps
 
+  // INFO: If there is metadata, you're in the metrics explorer context
+  const canAddConditions = !!alertsContext.metadata;
+
+  if (!canAddConditions && !alertParams.criteria) {
+    return (
+      <>
+        <EuiSpacer size={'m'} />
+        <EuiCallOut
+          title={
+            <>
+              <FormattedMessage
+                id="xpack.infra.metrics.alertFlyout.createAlertWarningBody"
+                defaultMessage="Create new metric threshold alerts from"
+              />{' '}
+              <EuiLink href={'../app/metrics/explorer'}>
+                <FormattedMessage
+                  id="xpack.infra.homePage.metricsExplorerTabTitle"
+                  defaultMessage="Metrics Explorer"
+                />
+              </EuiLink>
+              .
+            </>
+          }
+          color="warning"
+          iconType="help"
+        />
+        <EuiSpacer size={'m'} />
+      </>
+    );
+  }
+
   return (
     <>
       <EuiSpacer size={'m'} />
@@ -224,6 +258,7 @@ export const Expressions: React.FC<Props> = props => {
         alertParams.criteria.map((e, idx) => {
           return (
             <ExpressionRow
+              canEditAggField={canAddConditions}
               canDelete={alertParams.criteria.length > 1}
               fields={derivedIndexPattern.fields}
               remove={removeExpression}
@@ -246,69 +281,73 @@ export const Expressions: React.FC<Props> = props => {
       />
 
       <div>
-        <EuiButtonEmpty
-          color={'primary'}
-          iconSide={'left'}
-          flush={'left'}
-          iconType={'plusInCircleFilled'}
-          onClick={addExpression}
-        >
-          <FormattedMessage
-            id="xpack.infra.metrics.alertFlyout.addCondition"
-            defaultMessage="Add condition"
-          />
-        </EuiButtonEmpty>
+        {canAddConditions && (
+          <EuiButtonEmpty
+            color={'primary'}
+            iconSide={'left'}
+            flush={'left'}
+            iconType={'plusInCircleFilled'}
+            onClick={addExpression}
+          >
+            <FormattedMessage
+              id="xpack.infra.metrics.alertFlyout.addCondition"
+              defaultMessage="Add condition"
+            />
+          </EuiButtonEmpty>
+        )}
       </div>
 
       <EuiSpacer size={'m'} />
 
-      <EuiFormRow
-        label={i18n.translate('xpack.infra.metrics.alertFlyout.filterLabel', {
-          defaultMessage: 'Filter (optional)',
-        })}
-        helpText={i18n.translate('xpack.infra.metrics.alertFlyout.filterHelpText', {
-          defaultMessage: 'Use a KQL expression to limit the scope of your alert trigger.',
-        })}
-        fullWidth
-        compressed
-      >
-        <MetricsExplorerKueryBar
-          derivedIndexPattern={derivedIndexPattern}
-          onSubmit={onFilterQuerySubmit}
-          value={alertParams.filterQuery}
-        />
-      </EuiFormRow>
-
-      <EuiSpacer size={'m'} />
-
       {alertsContext.metadata && (
-        <EuiFormRow
-          label={i18n.translate('xpack.infra.metrics.alertFlyout.createAlertPerText', {
-            defaultMessage: 'Create alert per (optional)',
-          })}
-          helpText={i18n.translate('xpack.infra.metrics.alertFlyout.createAlertPerHelpText', {
-            defaultMessage:
-              'Create an alert for every unique value. For example: "host.id" or "cloud.region".',
-          })}
-          fullWidth
-          compressed
-        >
-          <MetricsExplorerGroupBy
-            onChange={onGroupByChange}
-            fields={derivedIndexPattern.fields}
-            options={{
-              ...options,
-              groupBy: alertParams.groupBy || undefined,
-            }}
-          />
-        </EuiFormRow>
+        <>
+          <EuiFormRow
+            label={i18n.translate('xpack.infra.metrics.alertFlyout.filterLabel', {
+              defaultMessage: 'Filter (optional)',
+            })}
+            helpText={i18n.translate('xpack.infra.metrics.alertFlyout.filterHelpText', {
+              defaultMessage: 'Use a KQL expression to limit the scope of your alert trigger.',
+            })}
+            fullWidth
+            compressed
+          >
+            <MetricsExplorerKueryBar
+              derivedIndexPattern={derivedIndexPattern}
+              onSubmit={onFilterQuerySubmit}
+              value={alertParams.filterQuery}
+            />
+          </EuiFormRow>
+
+          <EuiSpacer size={'m'} />
+          <EuiFormRow
+            label={i18n.translate('xpack.infra.metrics.alertFlyout.createAlertPerText', {
+              defaultMessage: 'Create alert per (optional)',
+            })}
+            helpText={i18n.translate('xpack.infra.metrics.alertFlyout.createAlertPerHelpText', {
+              defaultMessage:
+                'Create an alert for every unique value. For example: "host.id" or "cloud.region".',
+            })}
+            fullWidth
+            compressed
+          >
+            <MetricsExplorerGroupBy
+              onChange={onGroupByChange}
+              fields={derivedIndexPattern.fields}
+              options={{
+                ...options,
+                groupBy: alertParams.groupBy || undefined,
+              }}
+            />
+          </EuiFormRow>
+        </>
       )}
     </>
   );
 };
 
 interface ExpressionRowProps {
   fields: IFieldType[];
+  canEditAggField: boolean;
   expressionId: number;
   expression: MetricExpression;
   errors: IErrorObject;
@@ -379,17 +418,20 @@ export const ExpressionRow: React.FC<ExpressionRowProps> = props => {
             </StyledExpression>
             {aggType !== 'count' && (
               <StyledExpression>
-                <OfExpression
-                  customAggTypesOptions={aggregationType}
-                  aggField={metric}
-                  fields={fields.map(f => ({
-                    normalizedType: f.type,
-                    name: f.name,
-                  }))}
-                  aggType={aggType}
-                  errors={errors}
-                  onChangeSelectedAggField={updateMetric}
-                />
+                {!props.canEditAggField && <DisabledAggField text={metric || ''} />}
+                {props.canEditAggField && (
+                  <OfExpression
+                    customAggTypesOptions={aggregationType}
+                    aggField={metric}
+                    fields={fields.map(f => ({
+                      normalizedType: f.type,
+                      name: f.name,
+                    }))}
+                    aggType={aggType}
+                    errors={errors}
+                    onChangeSelectedAggField={updateMetric}
+                  />
+                )}
               </StyledExpression>
             )}
             <StyledExpression>
@@ -421,6 +463,19 @@ export const ExpressionRow: React.FC<ExpressionRowProps> = props => {
   );
 };
 
+export const DisabledAggField = ({ text }: { text: string }) => {
+  return (
+    <EuiExpression
+      description={i18n.translate('xpack.infra.metrics.alertFlyout.of.buttonLabel', {
+        defaultMessage: 'of',
+      })}
+      value={text}
+      isActive={false}
+      color={'secondary'}
+    />
+  );
+};
+
 export const aggregationType: { [key: string]: any } = {
   avg: {
     text: i18n.translate('xpack.infra.metrics.alertFlyout.aggregationText.avg', {