[Monitoring] Fixed server response errors #63181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoristic
added
bug
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@elasticmachine merge upstream |
chrisronline
suggested changes
Apr 10, 2020
There was a problem hiding this comment.
Hold up. After using this PR some more, I'm seeing things like this in the logs:
server log [14:04:28.628] [error][monitoring][monitoring][plugins] { Error: Unable to find the cluster in the selected time range. UUID: ECEBF2VPQuCF9tbBKaLqXQ
at getClustersFromRequest (/Users/chris/dev/repos/kibana/x-pack/plugins/monitoring/server/lib/cluster/get_clusters_from_request.js:83:13)
at process._tickCallback (internal/process/next_tick.js:68:7)
data: null,
isBoom: true,
isServer: false,
output:
{ statusCode: 404,
payload:
{ statusCode: 404,
error: 'Not Found',
message:
'Unable to find the cluster in the selected time range. UUID: ECEBF2VPQuCF9tbBKaLqXQ' },
headers: {} },
reformat: [Function],
typeof: [Function: notFound] }
server log [14:04:28.628] [error][http] { AssertionError [ERR_ASSERTION]: Cannot wrap an error
at new AssertionError (internal/assert.js:269:11)
at Object.exports.assert (/Users/chris/dev/repos/kibana/node_modules/hoek/lib/index.js:736:11)
at internals.Toolkit.response (/Users/chris/dev/repos/kibana/node_modules/hapi/lib/toolkit.js:145:14)
at HapiResponseAdapter.toSuccess (/Users/chris/dev/repos/kibana/src/core/server/http/router/response_adapter.ts:94:8)
at HapiResponseAdapter.toHapiResponse (/Users/chris/dev/repos/kibana/src/core/server/http/router/response_adapter.ts:82:19)
at HapiResponseAdapter.handle (/Users/chris/dev/repos/kibana/src/core/server/http/router/response_adapter.ts:74:17)
at Router.handle (/Users/chris/dev/repos/kibana/src/core/server/http/router/router.ts:265:34)
at process._tickCallback (internal/process/next_tick.js:68:7)
generatedMessage: false,
name: 'AssertionError [ERR_ASSERTION]',
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '==' }
Good find! Looking into this now |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Apr 17, 2020
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Apr 17, 2020
* Fixed server response errors * Fixed async error Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Apr 17, 2020
* Fixed server response errors * Fixed async error Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 17, 2020
* master: (40 commits) [APM]Upgrade apm-rum agent to latest version to fix full page reload (elastic#63723) add deprecation warning for legacy 3rd party plugins (elastic#62401) Migrate timelion vis (elastic#62819) Replacebad scope link with actual values (elastic#63444) Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) (elastic#63111) [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends (elastic#61207) [Maps] fix term join agg key collision (elastic#63324) [Ingest] Fix agent config key sorting (elastic#63488) [Monitoring] Fixed server response errors (elastic#63181) update elastic charts to 18.3.0 (elastic#63732) Start services (elastic#63720) [APM] Encode spaces when creating ML job (elastic#63683) Uptime 7.7 docs (elastic#62228) [DOCS] Updates remote cluster and ccr docs (elastic#63517) [Maps] Add 3rd party vector tile support (elastic#62084) [Endpoint][EPM] Retrieve Index Pattern from Ingest Manager (elastic#63016) [Endpoint] Host Details Policy Response Panel (elastic#63518) [Uptime] Certificate expiration threshold settings (elastic#63682) Refactor saved object types to use `namespaceType` (elastic#63217) [SIEM][CASE] Create comments sequentially (elastic#63692) ...
igoristic
added a commit
that referenced
this pull request
Apr 17, 2020
igoristic
added a commit
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #62843
This was caused because we weren't try/catching our main resolve/reject state
Testing
Or, set up with self monitoring