Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) #63111

Merged
merged 12 commits into from
Apr 17, 2020
Merged

Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) #63111

merged 12 commits into from
Apr 17, 2020

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Apr 9, 2020 •
edited by mattkime
Loading

Part of #51322

Summary

Migrated create_index_pattern_wizard and its tests to typescript

For maintainers

@mattkime mattkime mentioned this pull request Apr 13, 2020
Closed
16 tasks
@VladLasitsa VladLasitsa self-assigned this Apr 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp marked this pull request as ready for review April 15, 2020 12:18
@alexwizp alexwizp requested a review from a team as a code owner April 15, 2020 12:18
@alexwizp alexwizp assigned mattkime and unassigned mattkime Apr 15, 2020
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

mattkime
mattkime requested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from one requested change.

...nagement/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.tsx Outdated Show resolved Hide resolved
@mattkime
Copy link
Contributor

@elasticmachine merge upstream

mattkime
mattkime requested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of items were overlooked in the removal of indexPatternCreationType from state

...nagement/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.tsx Outdated Show resolved Hide resolved
...nagement/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa merged commit b81f926 into elastic:master Apr 17, 2020
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Apr 17, 2020
@VladLasitsa @elasticmachine
Index pattern management UI -> TypeScript and New Platform Ready (cre…
ef4e406 
…ate_index_pattern_wizard) (elastic#63111)

* Migrated create_index_pattern_wizard and its tests to typescript

* Fixed types

* Fixed some comments

* Fixed comments

* Fixed types

* Fixed types

* Fixed snapshot

* Removed indexPatternCreationType from state.

* Fixed comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@VladLasitsa VladLasitsa mentioned this pull request Apr 17, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 17, 2020
@gmmorris
Merge branch 'master' into alerting/es-query
34e0612 
* master: (40 commits)
  [APM]Upgrade apm-rum agent to latest version to fix full page reload (elastic#63723)
  add deprecation warning for legacy 3rd party plugins (elastic#62401)
  Migrate timelion vis (elastic#62819)
  Replacebad scope link with actual values (elastic#63444)
  Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) (elastic#63111)
  [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends (elastic#61207)
  [Maps] fix term join agg key collision (elastic#63324)
  [Ingest] Fix agent config key sorting (elastic#63488)
  [Monitoring] Fixed server response errors (elastic#63181)
  update elastic charts to 18.3.0 (elastic#63732)
  Start services (elastic#63720)
  [APM] Encode spaces when creating ML job (elastic#63683)
  Uptime 7.7 docs (elastic#62228)
  [DOCS] Updates remote cluster and ccr docs (elastic#63517)
  [Maps] Add 3rd party vector tile support (elastic#62084)
  [Endpoint][EPM] Retrieve Index Pattern from Ingest Manager (elastic#63016)
  [Endpoint] Host Details Policy Response Panel (elastic#63518)
  [Uptime] Certificate expiration threshold settings (elastic#63682)
  Refactor saved object types to use `namespaceType` (elastic#63217)
  [SIEM][CASE] Create comments sequentially (elastic#63692)
  ...
VladLasitsa added a commit that referenced this pull request Apr 17, 2020
@VladLasitsa @elasticmachine
Index pattern management UI -> TypeScript and New Platform Ready (cre…
bc04e70 
…ate_index_pattern_wizard) (#63111) (#63819)

* Migrated create_index_pattern_wizard and its tests to typescript

* Fixed types

* Fixed some comments

* Fixed comments

* Fixed types

* Fixed types

* Fixed snapshot

* Removed indexPatternCreationType from state.

* Fixed comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VladLasitsa @elasticmachine @mattkime @kibanamachine @alexwizp