Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Propagate the correct error and statusCode when a request fails #62843

Closed
igoristic opened this issue Apr 7, 2020 · 2 comments · Fixed by #63181
Closed

[Monitoring] Propagate the correct error and statusCode when a request fails #62843

igoristic opened this issue Apr 7, 2020 · 2 comments · Fixed by #63181
Labels
bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:Monitoring Stack Monitoring team v8.0.0

Comments

@igoristic
Copy link
Contributor

I noticed that we don't always propagate relevant errors in Stack Monitoring, or more exactly the exact errors we get from the ES's request. Mainly because this file can overwrite the real error or withhold the statusCode
@igoristic igoristic added discuss enhancement New value added to drive a business result Team:Monitoring Stack Monitoring team v8.0.0 labels Apr 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Contributor

This sounds like a bug to me. We should push down the actual error to the client.

@chrisronline chrisronline added bug Fixes for quality problems that affect the customer experience and removed discuss labels Apr 7, 2020
@igoristic igoristic mentioned this issue Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:Monitoring Stack Monitoring team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Monitoring] Fixed server response errors igoristic/kibana
3 participants
@chrisronline @elasticmachine @igoristic