Use embeddable v2

[stacey-gammon]

For reviewers

dashboard_state_manager used to be the primary way the redux store was synced with app state. Redux was essentially replaced with the dashboard embeddable container. However rather than put this in dashboard state manager, the logic is split up between dashboard state manager and dashboard_app_controller. It's pretty illogical atm, but given that this entire flow needs some serious clean up, and that app state is going away, as is angular, I simply took the path of least resistance.

Moving forward I could see some next steps being:

• Adding a migration from SavedDashboardPanel to DashboardPanelState. The former is what is stored in the PanelsJSON, the latter is what the DashboardEmbeddableContainer expects. Any previous ad hoc migration logic that used to exist inside the dashboard grid has been moved into the dashboard app (so the new DashboardEmbeddableContainer expects data in a certain format, users of the system are required to make sure they send it over in that particular format).

Dev Docs

Any plugins written on the old embeddable infrastructure will need to be updated to use the new embeddable infrastructure. The Embeddables API allows you to add your own custom UI components to a dashboard, without having to go through the visualization plugin system. This infrastructure is highly unstable at the moment. Expect this API to change frequently over the ensuing months.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[nreese]

!this.input.isLayerTOCOpen is not needed in this check and will fire updateInput every time input.isLayerTOCOpen is false even if the value did not change.

Should just be
if (this.input.isLayerTOCOpen !== isLayerTOCOpen)

[nreese]

lgtm
code review, tested in chrome

[stacey-gammon]

Failed on Code Explore Repository Explore a repository Click file/directory on the file tree. I just merged master so I'm thinking this is flaky, and looks like it's failing in other prs too.

jenkins, test this

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[stacey-gammon]

I think the dashboard filtering before all hook is flaky.

-: dashboard filtering
[00:06:47]               └-> "before all" hook
[00:06:47]               └-> "before all" hook
[00:06:47]                 │ debg gotoDashboardLandingPage
[00:06:47]                 │ debg onDashboardLandingPage
[00:06:47]                 │ debg TestSubjects.exists(dashboardLandingPage)
[00:06:47]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="dashboardLandingPage"]') with timeout=5000
[00:06:47]               └-: adding a filter that excludes all data
[00:06:47]                 └-> "before all" hook
[00:06:47]                 └-> "before all" hook
[00:06:47]                   │ debg TestSubjects.exists(newItemButton)
[00:06:47]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="newItemButton"]') with timeout=2500
[00:06:50]                   │ debg TestSubjects.click(createDashboardPromptButton)
[00:06:50]                   │ debg Find.clickByCssSelector('[data-test-subj~="createDashboardPromptButton"]') with timeout=10000
[00:06:50]                   │ debg Find.findByCssSelector('[data-test-subj~="createDashboardPromptButton"]') with timeout=10000
[00:07:01]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj~="createDashboardPromptButton"])
[00:07:01]                   │      Wait timed out after 10190ms
[00:07:01]                   │ debg Find.findByCssSelector('[data-test-subj~="createDashboardPromptButton"]') with timeout=10000
[00:07:11]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj~="createDashboardPromptButton"])
[00:07:11]                   │      Wait timed out after 10020ms
[00:07:12]                   │ debg Find.findByCssSelector('[data-test-subj~="createDashboardPromptButton"]') with timeout=10000
[00:07:22]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj~="createDashboardPromptButton"])
[00:07:22]                   │      Wait timed out after 10529ms
[00:07:23]                   │ debg Find.findByCssSelector('[data-test-subj~="createDashboardPromptButton"]') with timeout=10000
[00:07:33]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj~="createDashboardPromptButton"])
[00:07:33]                   │      Wait timed out after 10400ms
[00:07:34]                   │ debg Find.findByCssSelector('[data-test-subj~="createDashboardPromptButton"]') with timeout=10000
[00:07:44]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj~="createDashboardPromptButton"])

not sure if this PR exacerbates the issue, but given the screenshot and output above I don't see why it would. I don't know why it's failing either, the screenshot looks like the createDashboardPromptButton should have been found.

[stacey-gammon]

Actually I think I see why that test is flaky.

    async clickNewDashboard() {
      // newItemButton button is only visible when dashboard listing table is displayed
      // (at least one dashboard).
      const exists = await testSubjects.exists('newItemButton');
      if (exists) {
        return await testSubjects.click('newItemButton');
      }

      // If no dashboards exist, then newItemButton to create a new dashboard.
      return await this.clickCreateDashboardPrompt();
    }

the page probably didn't finish loading so newItemButton didn't exist, which meant it tried to click the create new dashboard from the prompt, not the button in the table. This can be fixed in another PR, it's unrelated.

[stacey-gammon]

retest

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request