Dashboard embeddable container plugin #38974

stacey-gammon · 2019-06-14T11:40:54Z

Adding dashboard_embeddable_container plugin which uses the new embeddable API. Still no real life usage except in sample plugin.

The final step will be swapping out the old infrastructure with the new in the dashboard plugin, along with the three current embeddable types on the old infrastructure.

It shouldn't be a huge PR but I'm still trying to clean up some dashboard_app stuff, and migrations, to make it a little easier to review, so figured to not waste time I can send this one out separately.

elasticmachine · 2019-06-14T19:57:37Z

Pinging @elastic/kibana-app-arch

elasticmachine · 2019-06-14T19:58:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-06-14T20:04:01Z

...legacy/core_plugins/dashboard_embeddable_container/public/embeddable/grid/dashboard_grid.tsx

+  maximizedPanelId: string;
+  useMargins: boolean;
+}) {
+  // This is to prevent a bug where view mode changes when the panel is expanded.  View mode changes will trigger


Not a complete copy from the original dashboard_grid.tsx, some code was removed that I think is no longer needed with the newer styles, like the old onBlur, onFocus handling, and the in-grid panel migrations away from older style data is moved out, all migrations should have occurred before we get here, and data be in the shape we expect.

elasticmachine · 2019-06-14T21:11:30Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-06-14T22:37:36Z


16:14:51 java.nio.channels.ClosedChannelException
16:14:51 Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from kibana-ci-immutable-centos-1560542887749825301.c.elastic-ci-prod.internal/10.224.1.177:60116

jenkins, test this

elasticmachine · 2019-06-14T23:35:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-17T13:47:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-17T14:58:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-06-17T15:34:43Z

10:15:15 Running "run:checkCoreApiChanges" (run) task
10:15:15 yarn run v1.16.0
10:15:15 $ /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/node_modules/.bin/github-checks-reporter 'Check core API changes' node scripts/check_core_api_changes
10:15:16 { HttpError: Server Error
10:15:16     at response.text.then.message (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/node_modules/@octokit/request/lib/request.js:56:27)
10:15:16     at process._tickCallback (internal/process/next_tick.js:68:7)
10:15:16   name: 'HttpError',
10:15:16   status: 502,
10:15:16   headers:
10:15:16    { connection: 'close',
10:15:16      'content-length': '32',
10:15:16      'content-type': 'application/json',
10:15:16      date: 'Mon, 17 Jun 2019 14:15:16 GMT',
10:15:16      etag: '"5d079c81-20"',
10:15:16      server: 'GitHub.com',
10:15:16      'x-github-request-id': '85CC:1B8A:E4DF21:2400DFD:5D07A074' },
10:15:16   request:
10:15:16    { method: 'POST',
10:15:16      url:
10:15:16       'https://api.github.com/app/installations/739765/access_tokens',
10:15:16      headers:
10:15:16       { accept: 'application/vnd.github.machine-man-preview+json',
10:15:16         'user-agent': 'octokit-request.js/2.4.2 Node.js/10.15.2 (Linux 4.9; x64)',
10:15:16         authorization: 'bearer [REDACTED]',
10:15:16         'content-length': 0 } } }
10:15:16 error Command failed with exit code 1.

jenkins, test this

elasticmachine · 2019-06-17T16:32:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-18T12:47:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-06-18T12:53:11Z

Failed on

07:59:20 $ /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/node_modules/.bin/github-checks-reporter eslint node scripts/eslint --no-cache
08:01:31 { HttpError: request to https://api.github.com/app/installations/739765/access_tokens failed, reason: connect ETIMEDOUT 192.30.253.117:443
08:01:31     at fetch.then.then.catch.error (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/node_modules/@octokit/request/lib/request.js:94:13)
08:01:31     at process._tickCallback (internal/process/next_tick.js:68:7)
08:01:31   name: 'HttpError',
08:01:31   status: 500,
08:01:31   headers: {},
08:01:31   request:
08:01:31    { method: 'POST',
08:01:31      url:
08:01:31       'https://api.github.com/app/installations/739765/access_tokens',
08:01:31      headers:
08:01:31       { accept: 'application/vnd.github.machine-man-preview+json',
08:01:31         'user-agent': 'octokit-request.js/2.4.2 Node.js/10.15.2 (Linux 4.9; x64)',
08:01:31         authorization: 'bearer [REDACTED]',
08:01:31         'content-length': 0 } } }
08:01:31 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
08:01:31 error Command failed with exit code 1.

jenkins, test this

elasticmachine · 2019-06-18T20:37:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-19T13:23:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-19T20:11:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-21T11:38:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-21T12:26:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

streamich

It looks like my recent removal of createRegistry breaks this build.

src/legacy/core_plugins/dashboard_embeddable_container/public/actions/index.ts

src/legacy/core_plugins/dashboard_embeddable_container/index.ts

...y/core_plugins/dashboard_embeddable_container/public/embeddable/dashboard_container.test.tsx

...core_plugins/dashboard_embeddable_container/public/embeddable/dashboard_container_factory.ts

src/legacy/core_plugins/dashboard_embeddable_container/public/np_core.test.mocks.ts

elasticmachine · 2019-06-21T15:44:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-21T17:21:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-06-21T17:41:15Z

Looks like a flaky failure, everything passed but:

2:31:05 [16:31:05] x-pack [failed]
12:31:05 [16:31:05] → undefined
12:31:05 
12:31:05 ERROR x-pack failed
12:31:05 
12:31:05       <--- Last few GCs --->
12:31:05 
12:31:05       [3710:0x2984d60]   135891 ms: Mark-sweep 1376.1 (1448.5) -> 1360.6 (1448.6) MB, 887.7 / 0.0 ms  (average mu = 0.243, current mu = 0.206) allocation failure scavenge might not succeed
12:31:05       [3710:0x2984d60]   137009 ms: Mark-sweep 1376.0 (1449.1) -> 1360.9 (1448.6) MB, 923.3 / 0.0 ms  (average mu = 0.210, current mu = 0.175) allocation failure scavenge might not succeed
12:31:05 
12:31:05 
12:31:05       <--- JS stacktrace --->
12:31:05 
12:31:05       ==== JS stack trace =========================================
12:31:05 
12:31:05           0: ExitFrame [pc: 0x159fb5cdbe1d]
12:31:05       Security context: 0x083b3d69e6e1 <JSObject>
12:31:05           1: checkObjectLiteral(aka checkObjectLiteral) [0x1108c5bd43f1] [/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/x-pack/node_modules/typescript/lib/tsc.js:~39928] [pc=0x159fb739b8a2](this=0x150d3fc826f1 <undefined>,node=0x1eecb5489209 <Node map = 0x1ff0a7f3cc9>,checkMode=0x150d3fc826f1 <undefined>)
12:31:05           2: che...
12:31:05 
12:31:05 
12:31:06 GitHub checks API - 11934 remaining out of 12500/hour
12:31:06 error Command failed with exit code 1.

jenkins, test this

elasticmachine · 2019-06-21T18:43:03Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-24T14:18:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2019-06-24T15:59:58Z

Think I've addressed all pending comments, lmk if I missed anything!

stacey-gammon · 2019-06-25T12:43:19Z

src/legacy/core_plugins/dashboard_embeddable_container/public/index.scss

+
+// TODO: uncomment once the duplicate styles are removed from the dashboard app itself.
+// MUST STAY AT THE BOTTOM BECAUSE OF DARK THEME IMPORTS
+// @import './embeddable/index';


Over here, cc @cchaos

* Dashboard embeddable plugin * comment out duplicate scss styles * review: conform closer to NP standards * export/import from index file in folder

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch from c6dca72 to fd14ce5 Compare June 14, 2019 13:45

elastic deleted a comment from elasticmachine Jun 14, 2019

stacey-gammon added the release_note:skip Skip the PR/issue when compiling release notes label Jun 14, 2019

stacey-gammon changed the title ~~Wip~~ Dashboard embeddable container plugin Jun 14, 2019

stacey-gammon added the :AppArch label Jun 14, 2019

elastic deleted a comment from elasticmachine Jun 14, 2019

stacey-gammon commented Jun 14, 2019

View reviewed changes

stacey-gammon marked this pull request as ready for review June 14, 2019 20:13

stacey-gammon requested a review from a team as a code owner June 14, 2019 20:13

stacey-gammon requested review from streamich, ppisljar and lizozom June 14, 2019 20:14

stacey-gammon added the review label Jun 14, 2019

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch from ff5cede to 41672e9 Compare June 17, 2019 12:54

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch from 41672e9 to 140fd5c Compare June 17, 2019 13:58

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch 2 times, most recently from 4be536b to 0bdea47 Compare June 18, 2019 12:40

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch from 1600b8d to 7c69835 Compare June 19, 2019 12:13

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch from 7c69835 to f436730 Compare June 19, 2019 19:07

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch from ca7f0b8 to 8e1c294 Compare June 21, 2019 12:01

streamich reviewed Jun 21, 2019

View reviewed changes

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch 4 times, most recently from 84b903a to c314da3 Compare June 21, 2019 16:10

stacey-gammon added 4 commits June 24, 2019 09:12

Dashboard embeddable plugin

c7d1668

comment out duplicate scss styles

2e01b85

review: conform closer to NP standards

9f855e4

export/import from index file in folder

610b706

stacey-gammon force-pushed the 2019-06-10-dashboard_embeddable_plugin branch from be21a95 to 610b706 Compare June 24, 2019 13:12

streamich approved these changes Jun 25, 2019

View reviewed changes

stacey-gammon commented Jun 25, 2019

View reviewed changes

stacey-gammon merged commit 1bcf7ce into elastic:master Jun 25, 2019

stacey-gammon mentioned this pull request Jun 25, 2019

[7.x] Dashboard embeddable container plugin (#38974) #39573

Merged

stacey-gammon added a commit that referenced this pull request Jun 25, 2019

Dashboard embeddable container plugin (#38974) (#39573)

aa80766

* Dashboard embeddable plugin * comment out duplicate scss styles * review: conform closer to NP standards * export/import from index file in folder

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dashboard embeddable container plugin #38974

Dashboard embeddable container plugin #38974

stacey-gammon commented Jun 14, 2019 •

edited

Loading

elasticmachine commented Jun 14, 2019

elasticmachine commented Jun 14, 2019

stacey-gammon Jun 14, 2019

elasticmachine commented Jun 14, 2019

stacey-gammon commented Jun 14, 2019

elasticmachine commented Jun 14, 2019

elasticmachine commented Jun 17, 2019

elasticmachine commented Jun 17, 2019

stacey-gammon commented Jun 17, 2019

elasticmachine commented Jun 17, 2019

elasticmachine commented Jun 18, 2019

stacey-gammon commented Jun 18, 2019

elasticmachine commented Jun 18, 2019

elasticmachine commented Jun 19, 2019

elasticmachine commented Jun 19, 2019

elasticmachine commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

streamich left a comment

elasticmachine commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

stacey-gammon commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

elasticmachine commented Jun 24, 2019

stacey-gammon commented Jun 24, 2019

stacey-gammon Jun 25, 2019

Dashboard embeddable container plugin #38974

Dashboard embeddable container plugin #38974

Conversation

stacey-gammon commented Jun 14, 2019 • edited Loading

elasticmachine commented Jun 14, 2019

elasticmachine commented Jun 14, 2019

💚 Build Succeeded

stacey-gammon Jun 14, 2019

Choose a reason for hiding this comment

elasticmachine commented Jun 14, 2019

💔 Build Failed

stacey-gammon commented Jun 14, 2019

elasticmachine commented Jun 14, 2019

💚 Build Succeeded

elasticmachine commented Jun 17, 2019

💚 Build Succeeded

elasticmachine commented Jun 17, 2019

💔 Build Failed

stacey-gammon commented Jun 17, 2019

elasticmachine commented Jun 17, 2019

💚 Build Succeeded

elasticmachine commented Jun 18, 2019

💔 Build Failed

stacey-gammon commented Jun 18, 2019

elasticmachine commented Jun 18, 2019

💔 Build Failed

elasticmachine commented Jun 19, 2019

💚 Build Succeeded

elasticmachine commented Jun 19, 2019

💚 Build Succeeded

elasticmachine commented Jun 21, 2019

💔 Build Failed

elasticmachine commented Jun 21, 2019

💔 Build Failed

streamich left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 21, 2019

💔 Build Failed

elasticmachine commented Jun 21, 2019

💔 Build Failed

stacey-gammon commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

💚 Build Succeeded

elasticmachine commented Jun 24, 2019

💚 Build Succeeded

stacey-gammon commented Jun 24, 2019

stacey-gammon Jun 25, 2019

Choose a reason for hiding this comment

stacey-gammon commented Jun 14, 2019 •

edited

Loading