Final Embeddable API V2 PR

src/legacy/core_plugins/embeddable_api/public/containers/embeddable_child_panel.tsx

@@ -24,9 +24,9 @@ import React from 'react';
 import { EuiLoadingChart } from '@elastic/eui';
 import { InjectedIntl, injectI18n } from '@kbn/i18n/react';
 
-import { ErrorEmbeddable, IEmbeddable } from 'plugins/embeddable_api';
-
 import { Subscription } from 'rxjs';
+import { ErrorEmbeddable, IEmbeddable } from '../embeddables';
+
 import { EmbeddablePanel } from '../panel';
 import { IContainer } from './i_container';
 

src/legacy/core_plugins/embeddable_api/public/context_menu_actions/build_eui_context_menu_panels.ts

@@ -104,12 +104,10 @@ function convertPanelActionToContextMenuItem({
     'data-test-subj': `embeddablePanelAction-${action.id}`,
   };
 
-  if (action.getHref(actionContext) === undefined) {
-    menuPanelItem.onClick = () => {
-      action.execute(actionContext);
-      closeMenu();
-    };
-  }
+  menuPanelItem.onClick = () => {
+    action.execute(actionContext);
+    closeMenu();
+  };
 
   if (action.getHref(actionContext)) {
     menuPanelItem.href = action.getHref(actionContext);

src/legacy/core_plugins/embeddable_api/public/get_actions_for_trigger.ts

@@ -19,14 +19,13 @@
 
 import { Action } from './actions';
 import { IEmbeddable } from './embeddables';
-import { IContainer } from './containers';
 import { IRegistry, Trigger } from './types';
 
 export async function getActionsForTrigger(
   actionRegistry: IRegistry<Action>,
   triggerRegistry: IRegistry<Trigger>,
   triggerId: string,
-  context: { embeddable: IEmbeddable; container?: IContainer }
+  context: { embeddable: IEmbeddable; triggerContext?: { [key: string]: unknown } }
 ) {
   const trigger = triggerRegistry.get(triggerId);
 

src/legacy/core_plugins/embeddable_api/public/triggers/execute_trigger_actions.ts

@@ -34,6 +34,7 @@ export async function executeTriggerActions(
 ) {
   const actions = await getActionsForTrigger(actionRegistry, triggerRegistry, triggerId, {
     embeddable,
+    triggerContext,
   });
 
   if (actions.length > 1) {

src/legacy/core_plugins/kibana/public/dashboard/_hacks.scss

@@ -3,7 +3,7 @@
 /**
  * Needs to correspond with the react root nested inside angular.
  */
- dashboard-viewport-provider {
+ #dashboardViewport {
   flex: 1;
   display: flex;
   [data-reactroot] {

src/legacy/core_plugins/kibana/public/dashboard/_index.scss

@@ -16,6 +16,3 @@
 //   dshChart__legend-isLoading
 
 @import './dashboard_app';
-@import './grid/index';
-@import './panel/index';
-@import './viewport/index';