Add latency to index and node Elasticsearch stats #22625

ruflin · 2018-09-03T11:25:20Z

elasticmachine · 2018-09-03T13:08:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ruflin · 2018-09-03T13:22:16Z

x-pack/plugins/monitoring/server/routes/api/v1/elasticsearch/metric_set_node_detail.js

@@ -88,6 +88,14 @@ export const metricSets = {
    {
      keys: ['node_cgroup_periods', 'node_cgroup_throttled_count'],
      name: 'node_cgroup_stats'
+    },
+    {
+      keys: ['node_index_latency'],


Need to check this again, below are already query and index latency in the overview I just realised.

@pickypg I realised some screens we have in advanced and under the overview. I assume this is on purpose.

Yes, but that "purpose" was relatively arbitrary. Basically the goal with the original charts were that they were something everyone would want to look at while everything under "Advanced" may require more intimate knowledge (beit of the JVM or ES itself).

We also originally had a rule for no more than 6 charts on the non-Advanced screen, but that does not have to continue. It was arbitrary and the biggest benefit is that it prevents the need to scroll on large screens.

chrisronline · 2018-09-04T20:38:54Z

I think you need to set title properties for the relevant metrics to ensure these graphs have appropriate titles:

kibana/x-pack/plugins/monitoring/server/lib/metrics/elasticsearch/metrics.js

Line 65 in 94d99d6

title: 'Latency',

pickypg · 2018-10-15T23:32:09Z

Ping @ruflin. This one seems to have slipped away.

ruflin · 2018-10-16T11:07:46Z

x-pack/plugins/monitoring/public/views/elasticsearch/index/advanced/index.html

@@ -18,6 +18,7 @@
      <div class="col-md-6"><monitoring-chart series="pageData.metrics.index_throttling"/></div>
      <div class="col-md-6"><monitoring-chart series="pageData.metrics.index_disk"/></div>
      <div class="col-md-6"><monitoring-chart series="pageData.metrics.index_segment_count"/></div>
+      <div class="col-md-6"><monitoring-chart series="pageData.metrics.index_latency"/></div>


@chrisronline I'm trying to figure out how to set the title for this one. It seems to set the title from index_index_latency.

Yea the title is managed by the metric itself, so it's a little disconnected from the UI. You'll need to change it there

This is where I'm stuck. index_latency itself is not a metric but the name of 2 metrics combined. Interestingly in the UI it shows the title of the first metric.

The corresponding Javascript file defines that combined "series" name when it's a combined chart.

I noticed that you figured that out after reading this. But we do grab the first title:

https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/public/components/chart/get_title.js#L13-L19

Generally speaking though, we define unique metrics per display.

elasticmachine · 2018-10-16T12:59:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ruflin · 2018-10-17T07:51:18Z

x-pack/plugins/monitoring/public/views/elasticsearch/index/advanced/index.html

@@ -18,6 +18,7 @@
      <div class="col-md-6"><monitoring-chart series="pageData.metrics.index_throttling"/></div>
      <div class="col-md-6"><monitoring-chart series="pageData.metrics.index_disk"/></div>
      <div class="col-md-6"><monitoring-chart series="pageData.metrics.index_segment_count"/></div>
+      <div class="col-md-6"><monitoring-chart series="pageData.metrics.index_latency"/></div>


This is where I'm stuck. index_latency itself is not a metric but the name of 2 metrics combined. Interestingly in the UI it shows the title of the first metric.

ruflin · 2018-10-17T07:52:01Z

x-pack/plugins/monitoring/server/routes/api/v1/elasticsearch/metric_set_index_detail.js

+    },
+    {
+      keys: ['index_index_latency', 'index_query_latency'],
+      name: 'index_latency'


@chrisronline It's here that have have 2 metrics combined in 1 graph. Where do I modify the title of the graph. I tried to create an "empty" metric index_latency but this trick didn't work. It still picks the name of the first metric.

Right. It uses the title for the first metric found in the set, so in this case index_index_latency. That's what you're seeing right? That's the behavior I found as well

Yes, but in this case the title should not be from the first metric. And there are quite a few examples in Advance where this is also not the case but I didn't find out so far how this is changed. @pickypg might share some insights here?

Closes elastic#22503

elasticmachine · 2018-10-18T13:21:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ruflin · 2018-10-19T06:47:48Z

@chrisronline I fixed the title, thanks for the help. This should be ready for review.

elasticmachine · 2018-10-19T08:27:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-19T11:07:46Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline · 2018-10-22T14:18:56Z

retest

elasticmachine · 2018-10-22T20:43:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline · 2018-10-22T20:53:28Z

@ruflin To fix the test error, open this fixture, delete everything in the file, then paste all of this json and commit and push :)

ruflin · 2018-10-23T06:28:53Z

@chrisronline Thanks, will do that. I'm pretty sure there is also a command I could run to update this fixture?

elasticmachine · 2018-10-23T08:11:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-23T10:48:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-23T15:40:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chrisronline

LGTM!

Closes elastic#22503

Closes #22503

* fixing other bucket filters (#24217) * fixing other bucket filters * adding selenium tests * using lodash flatten * using lodash flatten * fixing based on tims review * Fix functional tests * [ML] Fixes font size of headings in anomalies table expanded row (#24390) * Use metric indices when displaying metrics in the waffle map (#24251) * Add drilldown to waffle map groupings (#24301) * Resolve known APIs (#24398) * Fix: Use basepath from state for socket path (#24369) Closes #23168 This PR uses the `basePath` constant from Angular to mount the client socket instance, allowing it to connect correctly even in when using a Space. ### Workpad correctly loading in a Space ![screenshot 2018-10-22 15 57 00](https://user-images.githubusercontent.com/404731/47324055-251a3f80-d613-11e8-9fb0-0b0eaa3b974d.png) ### List of workpads restricted to a space ![screenshot 2018-10-22 13 49 54](https://user-images.githubusercontent.com/404731/47319741-50496280-d604-11e8-8966-83ef3a9fb320.png) ### List of workpads restricted to default space ![screenshot 2018-10-22 13 50 37](https://user-images.githubusercontent.com/404731/47319747-593a3400-d604-11e8-960d-385c80c7638a.png) * [ML] Fixes check for lower memory limit. (#24323) - Fixes the job validation for the lower bound of the model memory limit. Previously the check was against zero, now it's again less than 1MB, which is the same as the backend expects. - If the user entered model memory limit is less than half the value of the estimated model memory limit, a warning type message gets triggered. If the user entered model memory limit is more than half the value but less then the actual value of the estimated model memory limit, then the already existing info type message is shown. The unit tests have been updated to reflect that behavior. * Euify and Reactify Query Bar Component (#23704) Implements query bar portion of https://elastic.github.io/eui/#/layout/header. Filter bar will come in another PR. Fixes #14086 Re-implements our query bar component in React using some EUI components. Existing typeahead and suggestion styles were copied over 1:1 for now after talking with Dave about it. In this PR I focused on reaching feature parity with the existing query bar. Some additional work would be needed before we could move this into EUI as a generic component that could be consumed by other plugins. Still needs some new tests and I suspect some old tests will need to be updated, but other than that this PR is functionally complete and ready for reviews. * Add latency to index and node Elasticsearch stats (#22625) Closes #22503 * [Infra UI] Adding time ranges to detail links (#24237) * [Infra UI] Adding time ranges to detail links - Adds timeranges to hosts, containers, and pods links - Fixes #24228 - Typos and what not prevented urls from working * remove argument hard coded formatting * Cleaning up query arg generation * Adding missing file * removing rison hard coded string * Make sure Vega tooltip isn't cut off (#24409) Make sure the vega options dropdown menu is visible * refactor infra folder to an ingest folder who allow multiple products under it * fix lint error * remove my temp folder * fix link for icon * rename xpack.infra or xpack/infra to xpack.ingest or xpack/ingest * update to ingest * no more infra * change graphql endpoint * fix test path * fix path for xpack infra test

ruflin added the Team:Monitoring Stack Monitoring team label Sep 3, 2018

ruflin mentioned this pull request Sep 3, 2018

[Monitoring] Add Node and Index level Latency Charts #22503

Closed

4 tasks

ruflin commented Sep 3, 2018

View reviewed changes

ruflin force-pushed the index-latency branch from b158aba to bb3ad85 Compare October 16, 2018 11:06

ruflin commented Oct 16, 2018

View reviewed changes

ruflin commented Oct 17, 2018

View reviewed changes

ruflin added 2 commits October 18, 2018 13:40

Add latency to index and node Elasticsearch stats

89efc5f

Closes elastic#22503

cleanup

55200ca

ruflin changed the title ~~[WIP] Add latency to index and node Elasticsearch stats~~ Add latency to index and node Elasticsearch stats Oct 18, 2018

ruflin force-pushed the index-latency branch from bb3ad85 to 55200ca Compare October 18, 2018 11:40

fix title

58165f4

ruflin added the v6.5.0 label Oct 19, 2018

update snapshots

25091e5

update fixture

11dbd73

one more fix

6dcf3ee

Update fixture

f57f825

chrisronline approved these changes Oct 23, 2018

View reviewed changes

ruflin merged commit e8451ad into elastic:master Oct 23, 2018

ruflin deleted the index-latency branch October 23, 2018 17:26

ruflin mentioned this pull request Oct 23, 2018

[6.x] Add latency to index and node Elasticsearch stats (#22625) #24422

Merged

ruflin added a commit to ruflin/kibana that referenced this pull request Oct 23, 2018

Add latency to index and node Elasticsearch stats (elastic#22625)

e0d6127

Closes elastic#22503

ruflin added a commit that referenced this pull request Oct 23, 2018

Add latency to index and node Elasticsearch stats (#22625) (#24422)

9978cb9

Closes #22503

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add latency to index and node Elasticsearch stats #22625

Add latency to index and node Elasticsearch stats #22625

ruflin commented Sep 3, 2018

elasticmachine commented Sep 3, 2018

ruflin Sep 3, 2018

ruflin Oct 16, 2018

pickypg Oct 16, 2018

chrisronline commented Sep 4, 2018

pickypg commented Oct 15, 2018

ruflin Oct 16, 2018

chrisronline Oct 16, 2018

ruflin Oct 17, 2018

pickypg Oct 18, 2018

pickypg Oct 18, 2018

elasticmachine commented Oct 16, 2018

ruflin Oct 17, 2018

ruflin Oct 17, 2018

chrisronline Oct 17, 2018

ruflin Oct 18, 2018

elasticmachine commented Oct 18, 2018

ruflin commented Oct 19, 2018

elasticmachine commented Oct 19, 2018

elasticmachine commented Oct 19, 2018

chrisronline commented Oct 22, 2018

elasticmachine commented Oct 22, 2018

chrisronline commented Oct 22, 2018

ruflin commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

chrisronline left a comment

Add latency to index and node Elasticsearch stats #22625

Add latency to index and node Elasticsearch stats #22625

Conversation

ruflin commented Sep 3, 2018

elasticmachine commented Sep 3, 2018

💔 Build Failed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisronline commented Sep 4, 2018

pickypg commented Oct 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Oct 16, 2018

💔 Build Failed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Oct 18, 2018

💔 Build Failed

ruflin commented Oct 19, 2018

elasticmachine commented Oct 19, 2018

💔 Build Failed

elasticmachine commented Oct 19, 2018

💔 Build Failed

chrisronline commented Oct 22, 2018

elasticmachine commented Oct 22, 2018

💔 Build Failed

chrisronline commented Oct 22, 2018

ruflin commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

💔 Build Failed

elasticmachine commented Oct 23, 2018

💔 Build Failed

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

chrisronline left a comment

Choose a reason for hiding this comment