-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latency to index and node Elasticsearch stats #22625
Changes from all commits
89efc5f
55200ca
58165f4
25091e5
11dbd73
6dcf3ee
f57f825
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,6 +75,10 @@ export const metricSet = { | |
{ | ||
keys: ['index_segment_count_total', 'index_segment_count_primaries'], | ||
name: 'index_segment_count' | ||
}, | ||
{ | ||
keys: ['index_index_latency', 'index_query_latency'], | ||
name: 'index_latency' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @chrisronline It's here that have have 2 metrics combined in 1 graph. Where do I modify the title of the graph. I tried to create an "empty" metric There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right. It uses the title for the first metric found in the set, so in this case There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, but in this case the title should not be from the first metric. And there are quite a few examples in Advance where this is also not the case but I didn't find out so far how this is changed. @pickypg might share some insights here? |
||
} | ||
], | ||
overview: [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisronline I'm trying to figure out how to set the title for this one. It seems to set the title from
index_index_latency
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea the title is managed by the metric itself, so it's a little disconnected from the UI. You'll need to change it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where I'm stuck. index_latency itself is not a metric but the name of 2 metrics combined. Interestingly in the UI it shows the title of the first metric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding Javascript file defines that combined "series" name when it's a combined chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you figured that out after reading this. But we do grab the first title:
https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/public/components/chart/get_title.js#L13-L19
Generally speaking though, we define unique metrics per display.