[Infra UI] Adding time ranges to detail links #24237

simianhacker · 2018-10-18T19:19:18Z

Adds time ranges to hosts, containers, and pods links
Fixes [Infra UI] Waffle Map and Metric Detail Page ignore arguments set via the URL #24228 - Typos and what not prevented urls from working

This PR is needed by the @elastic/apm team

The URL format for the detail pages will be:

/app/infra#/link-to/host-detail/{hostname}?to={toTimestamp}&from={fromTimestamp}

- Adds timeranges to hosts, containers, and pods links - Fixes elastic#24228 - Typos and what not prevented urls from working

simianhacker · 2018-10-18T19:20:25Z

@skh @weltenwort @XavierM I added all three of you to this PR but only one of you needs to review it. First come first review.

simianhacker · 2018-10-18T19:21:16Z

@makwarth Once this PR is merged I can get you that new URL.

elasticmachine · 2018-10-18T21:01:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

weltenwort · 2018-10-19T10:22:25Z

x-pack/plugins/infra/public/pages/link_to/redirect_to_container_detail.tsx

+  const to = getToFromLocation(location);
+  const from = getFromFromLocation(location);
+  const args =
+    to && from ? `?metricTime=(autoReload:!f,time:(from:${from},interval:>%3D1m,to:${to}))` : '';


This seems to encode a lot of knowledge about the structure of the url, which is owned by the <WithMetricsTimeUrlState> container. Faced a similar situation in

kibana/x-pack/plugins/infra/public/pages/link_to/redirect_to_host_logs.tsx

Lines 27 to 29 in eaa37c2

const searchString = compose(

replaceLogFilterInQueryString(`${configuredFields.host}: ${match.params.hostname}`),

replaceLogPositionInQueryString(getTimeFromLocation(location))

which I tried to solve by defining the serialization function alongside the container in

kibana/x-pack/plugins/infra/public/containers/logs/with_log_position.tsx

Lines 117 to 125 in eaa37c2

export const replaceLogPositionInQueryString = (time: number) =>

Number.isNaN(time)

? (value: string) => value

: replaceStateKeyInQueryString<LogPositionUrlState>('logPosition', {

position: {

time,

tiebreaker: 0,

},

});

while re-using the common replaceStateKeyInQueryString function. That way a change of the serialization format would not break the redirection components.

Do you think something like this would be applicable here and in the corresponding functions RedirectToHostDetail and RedirectToPodDetail too?

…etail-linkto

elasticmachine · 2018-10-19T20:42:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-19T21:29:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

simianhacker · 2018-10-19T22:03:33Z

retest

…etail-linkto

elasticmachine · 2018-10-19T22:25:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-22T21:48:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

simianhacker · 2018-10-22T22:27:13Z

jenkins test this

elasticmachine · 2018-10-23T01:03:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

weltenwort

Works as expected if you specify to and from or none of them. 👍

If only one of them is specified, it is ignored. I guess that's intentional and fits our use cases?

weltenwort · 2018-10-23T09:39:31Z

x-pack/plugins/infra/public/pages/link_to/create_query_string_for_detail_time.ts

+  const to = getToFromLocation(location);
+  const from = getFromFromLocation(location);
+  return to && from
+    ? `?metricTime=(autoReload:!f,time:(from:${from},interval:>%3D1m,to:${to}))`


It would really be awesome if we could abstract away that manual rison construction using the replaceStateKeyInQueryString function, but this works too.

XavierM

LGTM

elasticmachine · 2018-10-23T18:27:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* [Infra UI] Adding time ranges to detail links - Adds timeranges to hosts, containers, and pods links - Fixes elastic#24228 - Typos and what not prevented urls from working * remove argument hard coded formatting * Cleaning up query arg generation * Adding missing file * removing rison hard coded string

* [Infra UI] Adding time ranges to detail links - Adds timeranges to hosts, containers, and pods links - Fixes #24228 - Typos and what not prevented urls from working * remove argument hard coded formatting * Cleaning up query arg generation * Adding missing file * removing rison hard coded string

* fixing other bucket filters (#24217) * fixing other bucket filters * adding selenium tests * using lodash flatten * using lodash flatten * fixing based on tims review * Fix functional tests * [ML] Fixes font size of headings in anomalies table expanded row (#24390) * Use metric indices when displaying metrics in the waffle map (#24251) * Add drilldown to waffle map groupings (#24301) * Resolve known APIs (#24398) * Fix: Use basepath from state for socket path (#24369) Closes #23168 This PR uses the `basePath` constant from Angular to mount the client socket instance, allowing it to connect correctly even in when using a Space. ### Workpad correctly loading in a Space ![screenshot 2018-10-22 15 57 00](https://user-images.githubusercontent.com/404731/47324055-251a3f80-d613-11e8-9fb0-0b0eaa3b974d.png) ### List of workpads restricted to a space ![screenshot 2018-10-22 13 49 54](https://user-images.githubusercontent.com/404731/47319741-50496280-d604-11e8-8966-83ef3a9fb320.png) ### List of workpads restricted to default space ![screenshot 2018-10-22 13 50 37](https://user-images.githubusercontent.com/404731/47319747-593a3400-d604-11e8-960d-385c80c7638a.png) * [ML] Fixes check for lower memory limit. (#24323) - Fixes the job validation for the lower bound of the model memory limit. Previously the check was against zero, now it's again less than 1MB, which is the same as the backend expects. - If the user entered model memory limit is less than half the value of the estimated model memory limit, a warning type message gets triggered. If the user entered model memory limit is more than half the value but less then the actual value of the estimated model memory limit, then the already existing info type message is shown. The unit tests have been updated to reflect that behavior. * Euify and Reactify Query Bar Component (#23704) Implements query bar portion of https://elastic.github.io/eui/#/layout/header. Filter bar will come in another PR. Fixes #14086 Re-implements our query bar component in React using some EUI components. Existing typeahead and suggestion styles were copied over 1:1 for now after talking with Dave about it. In this PR I focused on reaching feature parity with the existing query bar. Some additional work would be needed before we could move this into EUI as a generic component that could be consumed by other plugins. Still needs some new tests and I suspect some old tests will need to be updated, but other than that this PR is functionally complete and ready for reviews. * Add latency to index and node Elasticsearch stats (#22625) Closes #22503 * [Infra UI] Adding time ranges to detail links (#24237) * [Infra UI] Adding time ranges to detail links - Adds timeranges to hosts, containers, and pods links - Fixes #24228 - Typos and what not prevented urls from working * remove argument hard coded formatting * Cleaning up query arg generation * Adding missing file * removing rison hard coded string * Make sure Vega tooltip isn't cut off (#24409) Make sure the vega options dropdown menu is visible * refactor infra folder to an ingest folder who allow multiple products under it * fix lint error * remove my temp folder * fix link for icon * rename xpack.infra or xpack/infra to xpack.ingest or xpack/ingest * update to ingest * no more infra * change graphql endpoint * fix test path * fix path for xpack infra test

[Infra UI] Adding time ranges to detail links

eaa37c2

- Adds timeranges to hosts, containers, and pods links - Fixes elastic#24228 - Typos and what not prevented urls from working

simianhacker added review v7.0.0 v6.5.0 :Ingest UI labels Oct 18, 2018

simianhacker requested review from weltenwort, skh and XavierM October 18, 2018 19:19

weltenwort reviewed Oct 19, 2018

View reviewed changes

weltenwort mentioned this pull request Oct 19, 2018

[Infra UI] Waffle Map and Metric Detail Page ignore arguments set via the URL #24228

Closed

simianhacker added 3 commits October 19, 2018 11:29

Merge branch 'master' of github.com:elastic/kibana into add-time-to-d…

b450301

…etail-linkto

remove argument hard coded formatting

f74c173

Merge branch 'master' of github.com:elastic/kibana into add-time-to-d…

c988fec

…etail-linkto

simianhacker added 2 commits October 19, 2018 15:04

Merge branch 'master' of github.com:elastic/kibana into add-time-to-d…

8c7dd41

…etail-linkto

Cleaning up query arg generation

dee2ad1

Adding missing file

94efc61

weltenwort approved these changes Oct 23, 2018

View reviewed changes

XavierM approved these changes Oct 23, 2018

View reviewed changes

removing rison hard coded string

14833c6

simianhacker merged commit 3a6a3ea into elastic:master Oct 23, 2018

simianhacker mentioned this pull request Oct 23, 2018

[6.x] [Infra UI] Adding time ranges to detail links (#24237) #24427

Merged

simianhacker deleted the add-time-to-detail-linkto branch April 17, 2024 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infra UI] Adding time ranges to detail links #24237

[Infra UI] Adding time ranges to detail links #24237

simianhacker commented Oct 18, 2018 •

edited

Loading

simianhacker commented Oct 18, 2018

simianhacker commented Oct 18, 2018

elasticmachine commented Oct 18, 2018

weltenwort Oct 19, 2018

elasticmachine commented Oct 19, 2018

elasticmachine commented Oct 19, 2018

simianhacker commented Oct 19, 2018

elasticmachine commented Oct 19, 2018

elasticmachine commented Oct 22, 2018

simianhacker commented Oct 22, 2018

elasticmachine commented Oct 23, 2018

weltenwort left a comment •

edited

Loading

weltenwort Oct 23, 2018

XavierM left a comment

elasticmachine commented Oct 23, 2018

	const searchString = compose(
	replaceLogFilterInQueryString(`${configuredFields.host}: ${match.params.hostname}`),
	replaceLogPositionInQueryString(getTimeFromLocation(location))

	export const replaceLogPositionInQueryString = (time: number) =>
	Number.isNaN(time)
	? (value: string) => value
	: replaceStateKeyInQueryString<LogPositionUrlState>('logPosition', {
	position: {
	time,
	tiebreaker: 0,
	},
	});

[Infra UI] Adding time ranges to detail links #24237

[Infra UI] Adding time ranges to detail links #24237

Conversation

simianhacker commented Oct 18, 2018 • edited Loading

simianhacker commented Oct 18, 2018

simianhacker commented Oct 18, 2018

elasticmachine commented Oct 18, 2018

💚 Build Succeeded

weltenwort Oct 19, 2018

Choose a reason for hiding this comment

elasticmachine commented Oct 19, 2018

💚 Build Succeeded

elasticmachine commented Oct 19, 2018

💔 Build Failed

simianhacker commented Oct 19, 2018

elasticmachine commented Oct 19, 2018

💔 Build Failed

elasticmachine commented Oct 22, 2018

💔 Build Failed

simianhacker commented Oct 22, 2018

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

weltenwort left a comment • edited Loading

Choose a reason for hiding this comment

weltenwort Oct 23, 2018

Choose a reason for hiding this comment

XavierM left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

simianhacker commented Oct 18, 2018 •

edited

Loading

weltenwort left a comment •

edited

Loading