-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D3 Security Sub Actions Connector #158569
D3 Security Sub Actions Connector #158569
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
…nto new-connector-type-d3-security-v2
…nto new-connector-type-d3-security-v2
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, the connector works as expected. When testing the connector on the management page it works well, events are received correctly on the D3 side. And when attached to a rule the execution alerts are also received properly with all the expected values.
It is a bit weird that the "Event Type" and "Severity" params can be empty, they are set to undefined
on the D3 side, but as per the Schema they defined, it seems this is what they want.
code LGTM.
Thanks Steph! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
Summary
This code comes from a PR that was originally opened by the team at D3 Security. In an effort to get this merged, I have branched off of that PR and we will go forward with this one. This PR takes D3's connector code, refactors to use sub actions, and adds the appropriate tests and documentation.
Testing
Credentials
kibana.dev.yml
. This is the server I have set up with the D3 instance already. There is some configuration you need to do in D3 to establish the connection, so using this server will allow you to skip that step.More info
Below is the original PR description: