-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New action type - D3 security SOAR #137362
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
Hi @d3-naiji! Thank you so much for your contribution. I want to ask you if you want to support the connector in Cases? I am asking because Cases use a different flow that alerts. You can create an incident, update the incident, add comments, etc. To support both cases, the code needs to also consider the case user flow. |
Thanks for the PR, @d3-naiji! A couple things we'll need, beyond questions that Christos mentioned ^^^, if the desire is to ship this as-is vs as a case connector.
The last connector we added was xMatters in PR #122357 ; the "function test" I mentioned above are in the |
|
Hi @pmuellr , thanks for the information. We have signed CLA already. And will add the function test in the next commit. |
Thank you @d3-naiji. I would like to let you know that we have created a framework to aid developers in creating connectors in case you are interested. You can find the documentation here https://github.com/elastic/kibana/tree/main/x-pack/plugins/actions/server/sub_action_framework. I would suggest using it if you want to be "case" compatible in the future. |
Hi @cnasikas and @pmuellr, I have added the "funtion test" in the x-pack/test/alerting_api_integration directory and followed the instructions from https://www.elastic.co/guide/en/kibana/master/development-tests.html#development-functional-tests |
Hi, @d3-naiji I wanted to reach out, is there a point of contact we can talk to about setting up a real 'test instance' of the D3 Soar code base for on-going end to end validation? I can't commit to how fast we can work it, but I'm a good resource to kick that chat off. I can read up on the docs, too. TIA! |
Hi @EricDavisX , thanks for the update. I will prepare a document and a demo video about how to use the Kibane Connector to create events or trigger playbook flows in D3 SOAR. I will send you the documents and the 'test instance' in an email this week. |
@EricDavisX The document and D3 SOAR "test instance" info was sent to your email. |
Confirming as I understand it that @MindyRS 's team will take this on from testing side. I have forwarded the note to her I received. @MadameSheema and @asnehalb CC. Regards! |
@elasticmachine merge upstream |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/response-ops (Team:ResponseOps) |
@elasticmachine merge upstream |
@d3-naiji could you please update the PR and resolve the conflicts? I will be reviewing this PR today/this week. Thank you |
Hi @d3-naiji, thanks for the PR. FYI, the conflicts are caused by a migration of all connectors that happened last week. Now they live in the
|
buildkite test this |
Hi @semd , @EricDavisX , @stephmilovic , @pmuellr , @cnasikas. Sorry for the delay, the merge conflict has been already resolved and we have added some new features, please check the PR request below: Let me know if you have any questions. Thank you! |
buildkite test this |
Hi @d3-naiji, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New code need to be formatted using prettier
}), | ||
supportedFeatureIds: [ | ||
AlertingConnectorFeatureId, | ||
// CasesConnectorFeatureId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove comment
@@ -1,4 +1,4 @@ | |||
# Kibana Alerts and Actions UI | |||
# Kibana Alerts an3 Actions UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
// case 'success_put_method': | ||
// return validateRequestUsesMethod(request.method ?? '', 'put', response); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is PUT a valid method?
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
@EricDavisX @d3-naiji |
Hi @semd , have you received the test instance? Do you want me to send it again? |
Hi @EricDavisX @semd, |
This PR appears to be stale, and it seems the functionality it aimed to introduce has been addressed in a new PR #158569 that was branched off of this one. I'll go ahead and close this PR for now. If there's any reason to keep it open or further discuss its relevance, please feel free to reopen it. Thanks again for your contributions! |
Summary
Introduces a new built-in action type and sends the ElasticSearch alerts to D3 Security SOAR for incident response, workflow automation and deep investigation. This integrated alert action allows you to create Events or trigger Playbook workflow actions automatically in the D3 Security SOAR platform.
The new action type and the action connector with D3 Security SOAR are as follows:
and action params form available in Create Alert form:
![D3Security action form](https://camo.githubusercontent.com/54cbe8084b87cedcf0c6352e62753ed8b0c549460b4565bca4339f208bc4ef21/68747470733a2f2f692e696d6775722e636f6d2f5477696f5341302e706e67)
Checklist
Delete any items that are not applicable to this PR.
For maintainers
v8.3.3
Release_note:feature