Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Connector Type - D3 security SOAR #144955

Closed

Conversation

d3-naiji
Copy link

@d3-naiji d3-naiji commented Nov 9, 2022

Summary

Introduces a new built-in action type and sends the ElasticSearch alerts to D3 Security SOAR for incident response, workflow automation and deep investigation. This integrated alert action allows you to create Events or trigger Playbook workflow actions automatically in the D3 Security SOAR platform.

The new action type and the action connector with D3 Security SOAR are as follows:

D3ConnectorCard2

D3ConnectorForm1

and action params form available in Create Alert form:

D3_new-Form

OBS.: merge conflict has been resolved and new fields have been added for params form.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

(https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

@d3-naiji d3-naiji requested review from a team as code owners November 9, 2022 23:52
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@TinaHeiligers TinaHeiligers added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Nov 11, 2022
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial build failures:
console.log not allowed, please remove or use suitable log mocking

@TinaHeiligers
Copy link
Contributor

@elastic/response-ops could you please take a look at the proposal?

@TinaHeiligers TinaHeiligers added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Nov 11, 2022
@d3-naiji
Copy link
Author

initial build failures: console.log not allowed, please remove or use suitable log mocking

Hi @TinaHeiligers, we have already removed 'console.log' in the latest commits. Please, review it again. Thank you!

@d3-naiji
Copy link
Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor

@elastic/response-ops could you please take a look at the proposal?

@TinaHeiligers TinaHeiligers requested review from TinaHeiligers and removed request for TinaHeiligers November 16, 2022 23:27
@d3-naiji
Copy link
Author

d3-naiji commented Dec 1, 2022

@TinaHeiligers Hi Tina, any update from the code review? Is there anything we can help with?

@TinaHeiligers
Copy link
Contributor

@d3-naiji I am removing myself as a reviewer to allow the relevant team to take this further.

@TinaHeiligers TinaHeiligers requested review from TinaHeiligers and removed request for TinaHeiligers December 1, 2022 21:13
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @elastic/response-ops

@TinaHeiligers TinaHeiligers requested review from TinaHeiligers and removed request for TinaHeiligers December 1, 2022 21:15
@cnasikas
Copy link
Member

Hey @d3-bensong! Could you please address the CLA issue? Thanks!

@d3-naiji
Copy link
Author

cla-checker-service

Hi @cnasikas , I helped him sign the CLA, but it's after his commits. Could you help check if it can re-run the CLA checker and do I need to sign CLA for the developer again?

@cnasikas
Copy link
Member

@elasticmachine merge upstream

@cnasikas
Copy link
Member

buildkite test this

@cnasikas
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@cnasikas
Copy link
Member

@d3-naiji It seems that the CLA is fixed now. For some weird reason, I cannot merge with upstream. Could you please do it manually?

@cnasikas
Copy link
Member

@d3-naiji @d3-bensong Is there any plan to integrate the connector with Cases?

@d3-naiji
Copy link
Author

d3-naiji commented May 26, 2023

@d3-naiji @d3-bensong Is there any plan to integrate the connector with Cases?

Hi @cnasikas ,
We would like to enhance it in the future to support "Case".
The incident concept in D3 SOAR will align with the cases in Kinaba. In the future, we plan to integrate the connector with Case that will link to the "Incident Intake" function in D3 SOAR.

@stephmilovic
Copy link
Contributor

stephmilovic commented May 26, 2023

Screenshot 2023-05-26 at 12 07 25 PM

Is this intended?

@semd
Copy link
Contributor

semd commented May 29, 2023

buildkite test this

@semd
Copy link
Contributor

semd commented May 29, 2023

@elasticmachine, run elasticsearch-ci/docs

@d3-bensong
Copy link

Hi @cnasikas ,
We fixed problem, can you try again please?

@cnasikas
Copy link
Member

buildkite test this

@cnasikas
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 30, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackConnectors 195 201 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 440.0KB 449.5KB +9.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 33.4KB 34.2KB +782.0B
Unknown metric groups

async chunk count

id before after diff
stackConnectors 67 71 +4

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 401 405 +4
stackConnectors 87 93 +6
total +12

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 481 485 +4
stackConnectors 91 97 +6
total +12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@d3-bensong
Copy link

Hi @cnasikas,
I missed an issue last time, now fixed, could you try it again please, thanks.

@stephmilovic
Copy link
Contributor

Hello @d3-bensong and @d3-naiji. After review, because of the planned cases enhancements it was determined that the D3 Security connector needed to be transitioned to our sub actions framework. In order to move this PR forward in time for our upcoming 8.9 Feature Freeze date, we determined it would be most efficient if we move forward with an Elastic owned branch and have our team carry out the rest of the work. There is a new PR open with the sub actions refactor complete, along with additional required tests and documentation. We are moving forward with a review on that PR today. Your work is included in that PR. Therefore, you can go ahead and close this one. I will follow up over email to confirm once I have the new PR merged. Let me know if you have any questions.

Thank you!

@d3-naiji
Copy link
Author

d3-naiji commented Jun 1, 2023

@stephmilovic Thanks! I will close this PR

@d3-naiji d3-naiji closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💝community release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants