Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix logs useless rerender #155305

Merged
merged 1 commit into from
Apr 19, 2023
Merged

[Fleet] Fix logs useless rerender #155305

merged 1 commit into from
Apr 19, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Apr 19, 2023 •
edited by kibanamachine
Loading

Summary

Resolve #154315

The LogStream component was rendering every n seconds causing the UI to blink. That PR fix that.

Details

That PR fix that by removing the creation of a new logView object that we pass as a props each time.

Using React profiler before that change
Screenshot 2023-04-19 at 1 53 07 PM

How to test

Visit the agent details log page and verify that the log stream do not blink after waiting a few seconds.

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0 labels Apr 19, 2023
@nchaulet nchaulet self-assigned this Apr 19, 2023
@nchaulet nchaulet requested a review from a team as a code owner April 19, 2023 17:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Apr 19, 2023
@jen-huang jen-huang added release_note:fix backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 19, 2023
kpollich
kpollich approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just noticing this as well. Thanks - easy fix.

@nchaulet nchaulet enabled auto-merge (squash) April 19, 2023 18:14
@nchaulet nchaulet merged commit befd429 into elastic:main Apr 19, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 944.3KB 944.3KB +6.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@kibanamachine kibanamachine mentioned this pull request Apr 19, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 19, 2023
@nchaulet
[Fleet] Fix logs useless rerender (elastic#155305)
8fe15bf 
(cherry picked from commit befd429)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 19, 2023
@kibanamachine @nchaulet
[8.7] [Fleet] Fix logs useless rerender (#155305) (#155310)
5b805ac 
# Backport

This will backport the following commits from `main` to `8.7`:
- [[Fleet] Fix logs useless rerender
(#155305)](#155305)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2023-04-19T19:02:51Z","message":"[Fleet]
Fix logs useless rerender
(#155305)","sha":"befd429f4f70eb332b52e0a331b8e167ba0369f4","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Fleet","backport:prev-minor","v8.8.0"],"number":155305,"url":"https://github.com/elastic/kibana/pull/155305","mergeCommit":{"message":"[Fleet]
Fix logs useless rerender
(#155305)","sha":"befd429f4f70eb332b52e0a331b8e167ba0369f4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155305","number":155305,"mergeCommit":{"message":"[Fleet]
Fix logs useless rerender
(#155305)","sha":"befd429f4f70eb332b52e0a331b8e167ba0369f4"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
rylnd added a commit that referenced this pull request Apr 21, 2023
@rylnd
Merge branch '8.7' into risk_score_api_8.7
c70c7ea 
* 8.7: (93 commits)
  [8.7] [Controls] Use EUI Selectable for Field search (#151231) (#155454)
  [8.7] [Synthetics] Fix  performance breakdown link from error details page (#155393) (#155427)
  [8.7] [DOCS] Remove or move book-scoped attributes (#155210) (#155426)
  [8.7] [Synthetics] add default email recovery message (#154862) (#155418)
  [8.7] [Uptime] Add both both ip filters for view host in uptime location for host and monitor (#155382) (#155399)
  [8.7] Setup Node.js environment before instrumenting Kibana with APM. (#155063) (#155300)
  [8.7] [Discover] Address react warnings for legacy table (#154579) (#155345)
  [8.7] [Fleet] Fix logs useless rerender (#155305) (#155310)
  [8.7] [kbn-failed-test-reporter-cli] truncate report message to fix github api call failure (#155141) (#155286)
  [8.7][APM] Fleet migration support for bundled APM package (#153159)  (#155281)
  [8.7] [Enterprise Search] Fix Connector scheduling show week information correctly (#155191) (#155227)
  [8.7] [Synthetics] Fix pending count in case of location filtering (#155200) (#155225)
  [8.7] [Controls] Add Expensive Queries Fallback (#155082) (#155189)
  [8.7] [data view field editor] Runtime field code editor - move state out of controller (#155107) (#155150)
  [8.7] [FullStory] Update snippet (#153570) (#155138)
  [8.7] [Security Solution][Exceptions] - Fix exception operator logic when mapping conflict (#155071) (#155094)
  [DOCS] Adds 8.7.1 release notes (#154844)
  [8.7] Sync bundled packages with Package Storage (#155042)
  [APM] plugin description (#154811)
  Update api.asciidoc (#155021)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.7.1 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet]: Agent Logs tab getting auto refreshed frequently.
7 participants
@nchaulet @elasticmachine @apmmachine @kibana-ci @kibanamachine @kpollich @jen-huang