Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data view field editor] Runtime field code editor - move state out of controller #155107

Merged
merged 1 commit into from
Apr 18, 2023
Merged

[data view field editor] Runtime field code editor - move state out of controller #155107

merged 1 commit into from
Apr 18, 2023

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Apr 18, 2023 •
edited by kibanamachine
Loading

Summary

Resolves odd behavior with the runtime field code editor - most common case is inability to remove last character.

Move some field state back to react and out of controller.

Fixes #154351

@mattkime mattkime changed the title fix script field editor [data view field editor] Runtime field code editor - remove editorDidMount code Apr 18, 2023
@mattkime mattkime marked this pull request as ready for review April 18, 2023 04:25
@mattkime mattkime requested a review from a team as a code owner April 18, 2023 04:25
@mattkime mattkime changed the title [data view field editor] Runtime field code editor - remove editorDidMount code [data view field editor] Runtime field code editor - move state out of controller Apr 18, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewFieldEditor 156.1KB 156.1KB -10.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Runtime Fields Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Apr 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Apr 18, 2023
jughosta
jughosta approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@mattkime mattkime merged commit 7235345 into elastic:main Apr 18, 2023
@kibanamachine kibanamachine mentioned this pull request Apr 18, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 18, 2023
@mattkime
[data view field editor] Runtime field code editor - move state out o…
5ae4bc8 
…f controller (elastic#155107)

## Summary

Resolves odd behavior with the runtime field code editor - most common
case is inability to remove last character.

Move some field state back to react and out of controller.

Fixes elastic#154351

(cherry picked from commit 7235345)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@mattkime mattkime mentioned this pull request Apr 18, 2023
Merged
kibanamachine added a commit that referenced this pull request Apr 18, 2023
@kibanamachine @mattkime
[8.7] [data view field editor] Runtime field code editor - move state…
04befeb 
… out of controller (#155107) (#155150)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[data view field editor] Runtime field code editor - move state out
of controller (#155107)](#155107)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-04-18T12:36:20Z","message":"[data
view field editor] Runtime field code editor - move state out of
controller (#155107)\n\n## Summary\r\n\r\nResolves odd behavior with the
runtime field code editor - most common\r\ncase is inability to remove
last character.\r\n\r\nMove some field state back to react and out of
controller.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/154351","sha":"7235345601ec86df804afe1d8853aa8627482569","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data
Views","release_note:skip","Feature:Runtime
Fields","Team:DataDiscovery","backport:prev-minor","v8.8.0"],"number":155107,"url":"https://github.com/elastic/kibana/pull/155107","mergeCommit":{"message":"[data
view field editor] Runtime field code editor - move state out of
controller (#155107)\n\n## Summary\r\n\r\nResolves odd behavior with the
runtime field code editor - most common\r\ncase is inability to remove
last character.\r\n\r\nMove some field state back to react and out of
controller.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/154351","sha":"7235345601ec86df804afe1d8853aa8627482569"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155107","number":155107,"mergeCommit":{"message":"[data
view field editor] Runtime field code editor - move state out of
controller (#155107)\n\n## Summary\r\n\r\nResolves odd behavior with the
runtime field code editor - most common\r\ncase is inability to remove
last character.\r\n\r\nMove some field state back to react and out of
controller.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/154351","sha":"7235345601ec86df804afe1d8853aa8627482569"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <matt@mattki.me>
rylnd added a commit that referenced this pull request Apr 21, 2023
@rylnd
Merge branch '8.7' into risk_score_api_8.7
c70c7ea 
* 8.7: (93 commits)
  [8.7] [Controls] Use EUI Selectable for Field search (#151231) (#155454)
  [8.7] [Synthetics] Fix  performance breakdown link from error details page (#155393) (#155427)
  [8.7] [DOCS] Remove or move book-scoped attributes (#155210) (#155426)
  [8.7] [Synthetics] add default email recovery message (#154862) (#155418)
  [8.7] [Uptime] Add both both ip filters for view host in uptime location for host and monitor (#155382) (#155399)
  [8.7] Setup Node.js environment before instrumenting Kibana with APM. (#155063) (#155300)
  [8.7] [Discover] Address react warnings for legacy table (#154579) (#155345)
  [8.7] [Fleet] Fix logs useless rerender (#155305) (#155310)
  [8.7] [kbn-failed-test-reporter-cli] truncate report message to fix github api call failure (#155141) (#155286)
  [8.7][APM] Fleet migration support for bundled APM package (#153159)  (#155281)
  [8.7] [Enterprise Search] Fix Connector scheduling show week information correctly (#155191) (#155227)
  [8.7] [Synthetics] Fix pending count in case of location filtering (#155200) (#155225)
  [8.7] [Controls] Add Expensive Queries Fallback (#155082) (#155189)
  [8.7] [data view field editor] Runtime field code editor - move state out of controller (#155107) (#155150)
  [8.7] [FullStory] Update snippet (#153570) (#155138)
  [8.7] [Security Solution][Exceptions] - Fix exception operator logic when mapping conflict (#155071) (#155094)
  [DOCS] Adds 8.7.1 release notes (#154844)
  [8.7] Sync bundled packages with Package Storage (#155042)
  [APM] plugin description (#154811)
  Update api.asciidoc (#155021)
  ...
@jughosta jughosta mentioned this pull request May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Runtime Fields release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v8.7.1 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kbn code editor] Unable to remove last character in painless script editor
5 participants
@mattkime @kibana-ci @elasticmachine @kibanamachine @jughosta