Setup Node.js environment before instrumenting Kibana with APM. #155063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
release_note:skip
azasypkin
commented
Apr 17, 2023
| @@ -6,7 +6,6 @@ | |||
| * Side Public License, v 1. | |||
| */ | |||
|
|
|||
| require('@kbn/babel-register').install(); | |||
There was a problem hiding this comment.
note: require('@kbn/babel-register').install() is already done inside of setup_node_env.
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Apr 19, 2023
azasypkin
added
the
backport:all-open
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 19, 2023
…tic#155063) (cherry picked from commit eb90e40)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
azasypkin
added a commit
to azasypkin/kibana
that referenced
this pull request
Apr 20, 2023
…tic#155063) (cherry picked from commit eb90e40) # Conflicts: # src/cli/dev.js # src/cli/tsconfig.json
kibanamachine
added a commit
that referenced
this pull request
Apr 20, 2023
…#155063) (#155300) # Backport This will backport the following commits from `main` to `8.7`: - [Setup Node.js environment before instrumenting Kibana with APM. (#155063)](#155063) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Aleh Zasypkin","email":"aleh.zasypkin@elastic.co"},"sourceCommit":{"committedDate":"2023-04-19T16:33:11Z","message":"Setup Node.js environment before instrumenting Kibana with APM. (#155063)","sha":"eb90e40da5f48fa8554b495ecd9b046f5f5978e3","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","backport:all-open","v8.8.0"],"number":155063,"url":"https://github.com/elastic/kibana/pull/155063","mergeCommit":{"message":"Setup Node.js environment before instrumenting Kibana with APM. (#155063)","sha":"eb90e40da5f48fa8554b495ecd9b046f5f5978e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155063","number":155063,"mergeCommit":{"message":"Setup Node.js environment before instrumenting Kibana with APM. (#155063)","sha":"eb90e40da5f48fa8554b495ecd9b046f5f5978e3"}}]}] BACKPORT--> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@elastic.co>
azasypkin
added a commit
that referenced
this pull request
Apr 20, 2023
#155063) (#155378) # Backport This will backport the following commits from `main` to `7.17`: - [Setup Node.js environment before instrumenting Kibana with APM. (#155063)](#155063) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Aleh Zasypkin","email":"aleh.zasypkin@elastic.co"},"sourceCommit":{"committedDate":"2023-04-19T16:33:11Z","message":"Setup Node.js environment before instrumenting Kibana with APM. (#155063)","sha":"eb90e40da5f48fa8554b495ecd9b046f5f5978e3","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","backport:all-open","v8.8.0"],"number":155063,"url":"https://github.com/elastic/kibana/pull/155063","mergeCommit":{"message":"Setup Node.js environment before instrumenting Kibana with APM. (#155063)","sha":"eb90e40da5f48fa8554b495ecd9b046f5f5978e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155063","number":155063,"mergeCommit":{"message":"Setup Node.js environment before instrumenting Kibana with APM. (#155063)","sha":"eb90e40da5f48fa8554b495ecd9b046f5f5978e3"}},{"url":"https://github.com/elastic/kibana/pull/155300","number":155300,"branch":"8.7","state":"OPEN"}]}] BACKPORT-->
rylnd
added a commit
that referenced
this pull request
Apr 21, 2023
* 8.7: (93 commits) [8.7] [Controls] Use EUI Selectable for Field search (#151231) (#155454) [8.7] [Synthetics] Fix performance breakdown link from error details page (#155393) (#155427) [8.7] [DOCS] Remove or move book-scoped attributes (#155210) (#155426) [8.7] [Synthetics] add default email recovery message (#154862) (#155418) [8.7] [Uptime] Add both both ip filters for view host in uptime location for host and monitor (#155382) (#155399) [8.7] Setup Node.js environment before instrumenting Kibana with APM. (#155063) (#155300) [8.7] [Discover] Address react warnings for legacy table (#154579) (#155345) [8.7] [Fleet] Fix logs useless rerender (#155305) (#155310) [8.7] [kbn-failed-test-reporter-cli] truncate report message to fix github api call failure (#155141) (#155286) [8.7][APM] Fleet migration support for bundled APM package (#153159) (#155281) [8.7] [Enterprise Search] Fix Connector scheduling show week information correctly (#155191) (#155227) [8.7] [Synthetics] Fix pending count in case of location filtering (#155200) (#155225) [8.7] [Controls] Add Expensive Queries Fallback (#155082) (#155189) [8.7] [data view field editor] Runtime field code editor - move state out of controller (#155107) (#155150) [8.7] [FullStory] Update snippet (#153570) (#155138) [8.7] [Security Solution][Exceptions] - Fix exception operator logic when mapping conflict (#155071) (#155094) [DOCS] Adds 8.7.1 release notes (#154844) [8.7] Sync bundled packages with Package Storage (#155042) [APM] plugin description (#154811) Update api.asciidoc (#155021) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It looks like
setup_node_envdoesn't require any packages that would need to be instrumented by the APM, and hence it should be safe to require it before the APM script. Here are the 3rd-party packages that are required viasetup_node_envscripts (excluding anything that's imported inside of these package, of course):require-in-the-middlelodash/_isIterateeCallsymbol-observablesource-map-supportcore-js/stable@kbn/babel-register(only in dev, and it was already imported before APM script)