Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fallback for missing transaction.id in spans when creating an error link #135896

Merged
merged 2 commits into from
Jul 7, 2022
Merged

[APM] Fallback for missing transaction.id in spans when creating an error link #135896

merged 2 commits into from
Jul 7, 2022

Conversation

gbamparop
Copy link
Contributor

Summary

Fallback for missing transaction.id in spans when creating an error link

Closes #131050

@gbamparop gbamparop added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.4.0 labels Jul 7, 2022
@gbamparop gbamparop requested a review from a team as a code owner July 7, 2022 11:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #18 / Getting Started old charts library "after all" hook in "old charts library"
  • [job] [logs] FTR Configs #18 / Getting Started old charts library Shakespeare "after all" hook for "should change the Y-Axis extents"
  • [job] [logs] FTR Configs #18 / Getting Started old charts library Shakespeare "before all" hook for "should create shakespeare index pattern"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +76.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cauemarcondes
cauemarcondes approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbamparop gbamparop merged commit a1b68e4 into elastic:main Jul 7, 2022
@butlerx butlerx mentioned this pull request Jul 7, 2022
Closed
@gbamparop gbamparop mentioned this pull request Jul 18, 2022
Merged
gbamparop added a commit to gbamparop/kibana that referenced this pull request Jul 18, 2022
@gbamparop
Add transaction.id to kuery param only when it's defined (elastic#135896
919cb58 
)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a1b68e4)

# Conflicts:
#	x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/Waterfall/waterfall_item.tsx
gbamparop added a commit that referenced this pull request Jul 21, 2022
@gbamparop @kibanamachine
Add transaction.id to kuery param only when it's defined (#135896) (#…
961b4ad 
…136503)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a1b68e4)

# Conflicts:
#	x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/Waterfall/waterfall_item.tsx

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@gbamparop gbamparop mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.17.6 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Fallback for missing transaction.id in spans when using OTEL
5 participants
@gbamparop @elasticmachine @kibana-ci @cauemarcondes @kibanamachine