[APM] Clicking on the details of an error on the waterfall page fails with query transaction.id: "undefined"

[juan-domenech]

Kibana version:

7.17.2

Elasticsearch version:

7.17.2

Server OS version:

Centos 7

Browser version:

n/a

Browser OS version:

n/a

Original install method :

RPM x86_64

Describe the bug:

In APM Kibana UI, clicking through from an error on the trace waterfall to the error details page fails if the error is missing a transaction.id field.
This works fine if we pick the top error span but fails if we select an error span other than the first.
Kibana tries to run a query with transaction.id : "undefined" but finds no results because this query is incorrect.

This bug relates to this one #66363
and was not fixed by #66386
Details below.

Steps to reproduce:

1. Create an APM transaction with multiple error spans
2. Make sure some of the spans event do not have transaction.id
3. Click on any error span other than the first

Expected behavior:

As aptly stated in #66363

transaction.id should be omitted from the filter if the error does not have a transaction.id field. It is expected that some errors have a trace.id but no transaction.id, specifically in the case of Jaeger.

Screenshots:

Transaction example:

If we click on the second or the third error span the query is trace.id : "00000000000004640808702664403168" and transaction.id : "undefined"

Any additional context:

The check introduced in ErrorMarker.tsx https://github.com/elastic/kibana/pull/66386/files#diff-0bf8153c5620ab5d36f475d561830fcb32bc244f34831aa2c46e0871fc8bd5e8L65
does not cover the waterfall items.
The bug is still present at https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/waterfall_item.tsx#L271

Thanks!
Juan

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[gbamparop]

Thanks for raising this, it looks the same with #131050 that was originally raised for OTEL agents. Shall we close this?

[butlerx]

The fix (#135896) for #131050 is marked as not to backport but this issue is for v7

[gbamparop]

@butlerx I've backported it to 7.17 #136503

[juan-domenech]

Thank you @gbamparop !!!

[gbamparop]

Closing this as per above.