Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Cannot click through to details of an error on the waterfall page if the error is missing transaction.id #66386

Merged
merged 3 commits into from
May 14, 2020
Merged

[APM] Cannot click through to details of an error on the waterfall page if the error is missing transaction.id #66386

merged 3 commits into from
May 14, 2020

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented May 13, 2020 •
edited
Loading

closes #66363

Screenshot 2020-05-13 at 14 13 48

@cauemarcondes cauemarcondes requested a review from a team as a code owner May 13, 2020 11:50
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented May 13, 2020 •
edited
Loading

@sqren can you check it again please? I've changed the way the test expects the URL, I didn't like to previous. And I also removed the encodeURIComponent from ErrorMarker because it's already being encoded on APMLink.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 0fd5311 into elastic:master May 14, 2020
@cauemarcondes cauemarcondes deleted the error-marker branch May 14, 2020 05:04
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request May 14, 2020
@cauemarcondes
[APM] Cannot click through to details of an error on the waterfall pa…
b718171 
…ge if the error is missing `transaction.id` (elastic#66386)

* removing transaction from link when it isnt defined

* refacroting test

* refacroting test
This was referenced May 14, 2020
Merged
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request May 14, 2020
@cauemarcondes
[APM] Cannot click through to details of an error on the waterfall pa…
e4c2445 
…ge if the error is missing `transaction.id` (elastic#66386)

* removing transaction from link when it isnt defined

* refacroting test

* refacroting test
cauemarcondes added a commit that referenced this pull request May 14, 2020
@cauemarcondes
[APM] Cannot click through to details of an error on the waterfall pa…
ef5df39 
…ge if the error is missing `transaction.id` (#66386) (#66520)

* removing transaction from link when it isnt defined

* refacroting test

* refacroting test
cauemarcondes added a commit that referenced this pull request May 14, 2020
@cauemarcondes
[APM] Cannot click through to details of an error on the waterfall pa…
ab9a668 
…ge if the error is missing `transaction.id` (#66386) (#66522)

* removing transaction from link when it isnt defined

* refacroting test

* refacroting test
@juan-domenech juan-domenech mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:APM All issues that need APM UI Team support v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Cannot click through to details of an error on the waterfall page if the error is missing transaction.id
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv