Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fallback for missing transaction.id in spans when using OTEL #131050

Closed
LucaWintergerst opened this issue Apr 27, 2022 · 1 comment · Fixed by #135896
Closed

[APM] Fallback for missing transaction.id in spans when using OTEL #131050

LucaWintergerst opened this issue Apr 27, 2022 · 1 comment · Fixed by #135896
Assignees
Labels
apm:opentelemetry APM UI - OTEL Work apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.4.0

Comments

@LucaWintergerst
Copy link
Contributor

Kibana version: 8.2

Elasticsearch version: 8.2

Steps to reproduce:

  1. run app with OpenTelemtry, produce an error (ping me for a small sample app if you need one for testing)
  2. click on the view Error button

Any additional context:

When using OTEL (not sure if true for all OTEL Agents, I was using Java), there is a limitation that apm-server can't collect the transaction.id for a span. The trace.id is collected properly.

Screenshot 2022-04-27 at 13 05 43

The UI manages to properly visualize all of this data, however, the missing transaction.id causes problems when clicking on the relate errors, as Kibana now looks for trace.id : "c73283b7e7128e4216d520bb6ca0c47f" and transaction.id : "undefined". It usually gets this transaction.id from the span that the error belonged to.

Screenshot 2022-04-27 at 13 08 39

I see two possible fixes for this, but I have limited understand of the current code:

  • use the same logic that's used to visualize the spans in the first place, to read the transaction.id of the likely parent transaction, and then use that to filter
  • don't filter on the transaction.id field if it's empty, e.g. instead of searching for trace.id : "c73283b7e7128e4216d520bb6ca0c47f" and transaction.id : "undefined" just look for trace.id : "c73283b7e7128e4216d520bb6ca0c47f"
@LucaWintergerst LucaWintergerst added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Apr 27, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:opentelemetry APM UI - OTEL Work apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants