Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Convert Result Settings & Relevance Tuning pages to new page template #102845

Merged
merged 5 commits into from
Jun 22, 2021
Merged

[App Search] Convert Result Settings & Relevance Tuning pages to new page template #102845

merged 5 commits into from
Jun 22, 2021

Commits on Jun 22, 2021

  1. Convert Result Settings page to new page template 

    + remove wrapper around empty state (auto handled by new page template)
+ update tests w/ new test helpers
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    2870bfc View commit details
    Browse the repository at this point in the history

  2. Convert Relevance Tuning page to new page template 

    - Remove old relevance_tuning_layout (which handled breadcrumbs, page header, flash messages, and callouts) in favor of simply using the new templtate + callouts (yay DRYing)

- Remove panel wrapper around empty state (handled by new page template)
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f6f240d View commit details
    Browse the repository at this point in the history

  3. Update router

    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    3b0016a View commit details
    Browse the repository at this point in the history

  4. [Polish] Spacing & icon polish from Davey 

    see https://github.com/elastic/kibana/pull/101958/files
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    eb54dd3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into kibana-page-template-as-9

    Constance committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    642d4c4 View commit details
    Browse the repository at this point in the history